fix(governance): pin Hypatia baseline, warn≡medium, self-fresh lock gate - #1121
Merged
Merged
Conversation
Callers pinned to a pre-2026-10-01 governance-reusable copy check-package-policy.sh alone, so the resolver is absent by construction. Measured over the 325 local callers in that lone-file shape: 305 pass, 20 Nix-only fail, same as the full-layout run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016L7GFo3yGQ2vK9YgKL2wsP
- governance-reusable: baseline job pins hypatia via a `hypatia-ref` input (default 51ab6496, hypatia#895) instead of floating on HEAD. - apply-baseline.sh: treat `warn` and `medium` as one severity tier, so acknowledgements written before hypatia#895 still match (standards' own baseline had 20 such entries; all 20 now suppress). - Lock gate stages standards at job.workflow_sha, retiring the hardcoded third pin that went stale twice (#946, #1119). The freshness guard and both contract tests accept that expression and still refuse github.workflow_sha / github.sha (planted negatives). - check-package-policy: a missing capability resolver (old caller pin) warns and reads as undeclared instead of failing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016L7GFo3yGQ2vK9YgKL2wsP
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1120. It clears the two remaining reds on
main.Validate Hypatia Baseline (red on main):
warntomedium. Since then, the 20 RE001/RE005 acknowledgements in.hypatia-baseline.json(recorded aswarn) no longer match, so every caller whose baseline haswarnentries breaks.scripts/apply-baseline.shnow treatswarnandmediumas one tier.hypatia-refinput (default51ab6496).HEADremains accepted as an explicit opt-in for canaries.Repo self-tests (red on main):
5f82b635). That pin was one change behind by construction and went stale again with ci: drop embedded Python YAML parsing; gate inline Python #1119.${{ job.workflow_sha }}, the reusable's own commit, which is exactly what the caller pinned.check-lock-gate-pin-freshness.shand both contract tests accept that expression. They still refusegithub.workflow_sha/github.sha, which name the caller's commit (planted negatives: all three guards go red).Package policy: a caller pinned before the capability resolver existed now gets a warning and is treated as undeclared, instead of failing.
Local:
run-shell-test-suite.sh, all 69 files pass.docstring-scan --checkpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_016L7GFo3yGQ2vK9YgKL2wsP