Repository navigation
fix(applier): fail closed when a repo's workflows cannot be read - #1127
Merged
Merged
Conversation
fetch_workflows returned 0 on every REST failure, so a rate-limited repo read as "no workflows" and vanished from the pin census while `walked N` still counted it. Only a 404 now means "nothing here"; any other failure records a FETCH-FAILED row. An empty enumeration is fatal instead of an empty census. main is source-guarded so the fetch path is testable; the suite adds four known-answer cases and a fail-open mutant that turns red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016L7GFo3yGQ2vK9YgKL2wsP
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Autopilot could not be updated. Open Coding to check access and billing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_workflowsinscripts/apply-workflow-pins-remote.shreturned 0 on every REST failure. A rate-limited repo therefore read as "no workflows": it was dropped from the pin census whilewalked Nstill counted it. Measured on 2026-10-02, when the shared 5,000/h token ran out partway through an audit run.FETCH-FAILEDrow and the repo is not classified.mainis guarded onBASH_SOURCE, so the fetch path can be sourced and tested with a stubgh.tests/test_apply_workflow_pins_remote.shsection 3 adds four known-answer cases (ok, 404, rate-limited listing, failed file download). It also adds a mutant that puts back the fail-openreturn 0on a failed listing; that mutant turns red. Locally all sections pass and docstring coverage is 100%.Not changed here: if
list_reposis rate-limited partway through pagination, the list can still come back incomplete. The new guard only catches a list that is completely empty.🤖 Generated with Claude Code
https://claude.ai/code/session_016L7GFo3yGQ2vK9YgKL2wsP