feat(canon): Gate A assertion 3 reads the spine deed (canon …) clause - #1128
Merged
Merged
Conversation
The spine's canon pin moves from rsr-profile.a2ml [canon] (frozen by D43, so it could not follow canon 2.1.2) into a `(canon …)` clause of its repo deed (hyperpolymath/rsr-template-repo#215, #222). - 1-formats/deed/vocabulary/canon.adoc: the clause's terms and reader obligations, plus fixture canon-clause_chora.deed (deed_lint OK). - check-canon-lockstep.sh assertion 3 reads the single *_chora.deed and compares version, criteria and gates, shape-checking each value. The shared `deed_canon` reader is byte-identical with rsr's dogfood-gate and repo-init. A spine without the clause falls back to the legacy a2ml criteria hash, so Gate A works whichever PR lands first. - canon.lock: the current-reader comments name the deed. - scripts/tests/check-canon-lockstep-deed-test.sh: 9 cases. They include a wrong gates hash, a stale version, a malformed hash, a duplicated clause, two deeds, the legacy fallback, no pin at all, and the vocabulary fixture against the live canon. A mutant that makes every comparison pass is killed (2 reds). Against real spines: the rsr#222 head passes all three pins through the deed, and the rsr main pass is legacy criteria only. Full Gate A: passed 11, failed 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hw7qg3u9PAP6b2oKyVTSVC
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
enabled auto-merge (squash)
October 1, 2026 23:45
Contributor
|
Autopilot could not be updated. Open Coding to check access and billing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gate A assertion 3 now reads the spine's canon pin from its repo deed instead of from
rsr-profile.a2ml [canon]. This is the standards half of hyperpolymath/rsr-template-repo#215; the spine half is hyperpolymath/rsr-template-repo#222.Why: D43 freezes
.a2mlwrites, so the a2ml[canon]block could not follow canon 2.1.2, and the spine's lockstep job went red with nothing allowed to fix it. The owner ruled that the pin moves into the deed.1-formats/deed/vocabulary/canon.adoc: defines the(canon :version … :criteria-sha256 … :gates-sha256 … [:lockstep-since …])clause and the reader obligations. Readers require exactly one clause, check the shape of every value, ignore comment lines, and keep three byte-identical readers.tools/fixtures/valid/canon-clause_chora.deed:deed_lint.pypasses it (rc=0).scripts/check-canon-lockstep.shassertion 3:*_chora.deedand compares version, criteria and gates (previously criteria only).LEGACY, so Gate A stays correct whichever of the two PRs lands first.canon.lock: the current-reader comments name the deed. Historical narrative is left untouched.scripts/tests/check-canon-lockstep-deed-test.sh: 9 cases.canon.lock, so the test does not go stale on release.Evidence
LEGACYcriteria PASS.check-canon-lockstep.sh --spine <rsr#222>: passed 11, failed 0, GATE A PASSED.docstring-scan --worktree: 5/5 new functions documented.Not in this PR
🤖 Generated with Claude Code
https://claude.ai/code/session_01Hw7qg3u9PAP6b2oKyVTSVC