Feat/provisioning check reusable signed - #1130
Merged
Merged
Conversation
Re-signed rebuild of #1096 (head 18dcefa) on current main. Two coderabbitai[bot] commits on that branch were unsigned, which required_signatures refuses even under squash. The tree equals 18dcefa apart from main's later #1087/#1098 files, plus: - hypatia:ignore eval_in_shell pragmas on 7 lines of provision-check.sh and provision-lib.sh. Each hit is the word "eval" (a verb name or the .eval/ directory), never the shell builtin. Inline pragmas, not baseline entries: the templates are minted into other repos, where the pragma travels with them. Control: hypatia@4065424 reports 7 findings before and 0 after. Original commits (feat/provisioning-canon): fd0658c feat(provisioning): estate provisioning standard + launcher v0.5 modes e7b134e fix(provisioning): detect ABI/FFI layout; launcher is generated 40010ef fix(provisioning): no curl|sh install hint; regenerate registry 206eb6c feat(provisioning): one placement resolver; zig found 3 dirs down 39b790f fix(provisioning): no faked zig/bun tests; one ai-install sentence eaf3a89 feat(provisioning): fmt-check verb, the check-only twin of fmt b234caf fix(provisioning): #1096 review — hook isolation, dispatch rc, quoting 89c1d32 fix(provisioning): one set of predicates for doctor and the CI gate 93342bf docs(provisioning): banned-tool mise.toml is replaced; app launchers 7e6f3db feat(provisioning): toolchain-refresh regenerates build/guix/crates.scm 9b57453 fix(provisioning): mise.lock checksums are checked per platform table 7475b18 docs(provisioning): document the awk helper in mise_lock_gaps e323e0a docs(provisioning): escape the [[ai-install]] anchor in prose 42b66c3 fix(provisioning): guix-only re-pin, tally-last doctor, artefact kinds b01a245 fix(provisioning): PV-W23 reads every mise config and backend bf7c97a fix(provisioning): a bare mise name with only npm backends is banned a00fcf3 Update 3-practice/provisioning/templates/launcher.sh.tmpl 71cad01 docs(provisioning): document shell template functions 18dcefa docs(provisioning): clarify template function behavior and exit statuses Co-Authored-By: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DAKujx2PXHcVSA7vncTNH1
provisioning-check-reusable.yml checks a caller against the provisioning
canon at the workflow's own commit (job.workflow_sha), in two steps that
report separately:
- engine drift: build/just/{provision.just,provision-lib.sh,
provision-modes.sh,provision-check.sh} must be byte-identical to the
canon. channels.scm is not compared: toolchain-refresh re-pins it per
repo, and provision-check.sh checks the pin instead.
- conformance: the canon provision-check.sh (not the caller's copy) runs
against the caller without --dev, so template residue fails.
just 1.56.0 is installed from the release tarball pinned by sha256; no
new action is used. actions.lock gains the section by hand (the lock's
membership check is global, so a missing section would go unnoticed),
and canon.lock lists the reusable under [canon.workflows].
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UkSmyapDUmuGyyZSJmvbKy
(cherry picked from commit 96d5828)
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (25)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Type of change
How has this been verified?
Checklist
git commit -S).SPDX-License-Identifier(code/configMPL-2.0,prose
CC-BY-SA-4.0); I did not relicense existing files.Notes for reviewers