Skip to content

Finish line: opt-in, plainer, and about what to do #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarstelfox merged 6 commits into from
Oct 12, 2026
Merged

Finish line: opt-in, plainer, and about what to do #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5aa5527
Make PR jail opt-in and add a hold setting
jarstelfox Oct 12, 2026
75c51f0
Rename PR jail to Finish line and explain it
jarstelfox Oct 12, 2026
3d085bd
Lead Finish line with the action and its numbers
jarstelfox Oct 12, 2026
af6cdec
Say what "All finished" means, dim in dark mode
jarstelfox Oct 12, 2026
df9e4e8
Fix Finish line review findings
jarstelfox Oct 12, 2026
54d8430
Keep Finish line's focus in and its files in style
jarstelfox Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/repair-stale-open-pulls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Pulls whose `closed` webhook never landed stay open in the DB. Until the
* stale-open check listed repos outside config.repos, nothing repaired them
* there: 21 PRs closed 2026-09-26 to 09-30, while prod wrote into dev's DB,
* stayed open on prod (iFixit/ops#1055 in PR jail). The hourly repair now
* stayed open on prod (iFixit/ops#1055, counted against their owners' open-PR limits). The hourly repair now
* catches these; this fixes them without waiting for a deploy.
*
* It lists the open pulls of every repo the DB holds open pulls in and, with
Expand Down
9 changes: 7 additions & 2 deletions frontend-v2/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ import { Stats } from './views/Stats';
import type { ProjectsNav } from './views/Projects';
import { Search } from './views/Search';
import { Settings } from './components/Settings';
import { JailMode } from './components/JailMode';
import { FinishLine } from './components/FinishLine';

export type { Lens };

Expand Down Expand Up @@ -1142,7 +1142,12 @@ export function App() {
>
v1 board
</a>
<JailMode pulls={pulls} me={me} extraBots={extraBots} initialized={initialized} />
<FinishLine
pulls={pulls}
me={me}
extraBots={extraBots}
initialized={initialized}
/>
<NotificationPanel
records={liveHistory}
onClear={clearHistory}
Expand Down
Loading
Loading