Skip to content

Add support for TalkTalk-branded router (UK) #387

Description

@mr-miles

Model information

F5364 from TalkTalk

Describe the bug

GetDeviceInfo is failing because this particular flavour of router doesn't have a ModelNumber.
Otherwise the library is working great!
Impact is that HA is unable to connect to the router since an exception is thrown in the setup.

Expected behavior

I think ModelNumber is not important in the bigger scheme and could be defaulted to blank.

Additional context

I've submitted a PR that fixes this - #386 - and also provides better support for ActionErrors when the request contains multiple xpaths.

[bug]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions