[iStorry]

Follows #1, which moved the bundle ID to com.istorry.Whisky.

Why

Bottles (~/Library/Containers/<bundle-id>/BottleVM.plist), WhiskyWine (~/Library/Application Support/<bundle-id>/Libraries) and settings are all keyed by bundle ID. After the move to com.istorry.Whisky, anyone switching from upstream Whisky would see an empty bottle list and have to download Wine again from upstream's server.

What

UpstreamDataMigration.migrateIfNeeded() runs once, from WhiskyApp.init (before BottleVM.shared creates our bottle list) and from WhiskyCmd's main:

1. Settings: keys missing from our domain are copied from com.isaacmarovitz.Whisky. A defaultBottleLocation that points at upstream's own Bottles folder is skipped, so new bottles go into our container. A custom location is kept.
2. WhiskyWine: upstream's Libraries folder is moved into ours if we don't have one yet. DLLs are copied into bottles, not linked, so nothing points back into the old location.
3. Bottle list: upstream's paths are merged into ours, skipping duplicates. Bottles are not moved. Programs inside Wine prefixes record absolute paths, and macOS treats the upstream folder as a protected app container whose folder can't be renamed or removed. Its contents stay readable and writable.

Each step is idempotent. Completion is recorded only after all steps succeed, so a failure shows an alert in the app (stderr in the CLI) and is retried on the next launch.

Supporting refactors:

• BottleData and WhiskyWineInstaller paths are now derived per bundle ID, so the upstream locations reuse the same code.
• BottleData gained a throwing write() (the old encode() wraps it, behaviour unchanged).
• defaultBottleLocation is now a named constant instead of a string literal repeated in two views.

Also adds docs/upstream-issue-triage.md: a priority-ranked triage (P0–P3) of the 433 open upstream Whisky-App/Whisky issues, grouped by underlying problem, to plan work on the fork.

Verification

• swiftlint --strict, Debug and Release xcodebuild for Whisky and WhiskyCmd pass with no project warnings.
• Ran WhiskyCmd against fake upstream data in ~/Library:
  • fresh install, no upstream data → marked complete, nothing imported
  • upstream bottle plus a duplicate custom-path bottle → upstream bottle imported once, duplicate skipped
  • Wine moved; settings copied without overwriting existing ones; upstream-default defaultBottleLocation skipped, custom one kept
  • after completion, newly added upstream bottles are not re-imported
  • corrupt upstream BottleVM.plist → error on stderr, Wine still moved, not marked complete; succeeds on the next run once fixed

Not verified:

• The alert has not been seen in the running app.
• Whether a signed build triggers macOS's "would like to access data from other apps" prompt when it reads upstream's container. If it does and the user declines, the migration fails and is retried on the next launch.
• New strings are English only; Crowdin will pick them up.