[iStorry]

Fixes the P0 groups from docs/upstream-issue-triage.md that are in Whisky's own code, and moves the WhiskyWine runtime to this repository because upstream's host is gone.

Why

data.getwhisky.app/Wine/Libraries.tar.gz and its version file now return 404. Setup saved the 404 page as the download, extracting it failed silently, setup still reported success, and with no Wine installed every new bottle removed itself without a message. Most of the "bottles disappear" reports trace back to that chain of silent failures.

What changed

100% CPU (Whisky-App#1010, Whisky-App#1031)

• Clear each pipe's readability handler at end of file. Foundation keeps calling it on a closed pipe, so every finished process left a reader spinning a full core. A standalone copy of the old pattern used 1.00s of CPU per idle second; the fix uses 0.00s.
• Finish the output stream once the process has exited and both pipes have closed, instead of blocking the termination handler in readToEnd() while child processes still hold the pipes.

Logs filling the disk (Whisky-App#1005, Whisky-App#1115, Whisky-App#1261)

• Each process log stops at 100 MB with one truncation notice.
• Logs older than 7 days are deleted, then the oldest until the folder fits in 1 GB.
• Log file names are unique, so two runs in the same second no longer share and truncate one file.

WhiskyWine download and install (Whisky-App#801, Whisky-App#995, Whisky-App#1020, Whisky-App#1271, Whisky-App#1275)

• Non-200 responses are rejected, and the download is moved out of URLSession's temporary location before the completion handler returns.
• The archive is extracted into a staging folder, and Libraries is replaced only once the new runtime has a version file. tar failures are no longer ignored.
• Download and install failures show the error with a Retry button.
• Updating no longer uninstalls the working runtime before the new one has downloaded.

Bottle creation (Whisky-App#359, Whisky-App#760, Whisky-App#819, Whisky-App#1237, Whisky-App#1364 and duplicates)

• A failed bottle shows an alert with the reason: WhiskyWine missing, a folder name ending in a period (Wine drops trailing dots when mapping paths), or Wine not creating the prefix, with Wine's output.
• The half-created bottle folder is removed on failure.
• Bottles still being created survive list reloads.
• Creation runs on the main actor instead of changing published state from a detached task.
• An unreadable bottle list is moved aside instead of being overwritten with an empty list.

Runtime hosting

• The app downloads Libraries.tar.gz and WhiskyWineVersion.plist from the whiskywine release of this repository. WhiskyWine 2.5.0 is already published there.
• scripts/publish-whiskywine.sh packages a built Libraries folder and replaces both assets.
• The published runtime is upstream's last archive (24 Aug 2025), taken from the Internet Archive. It matches the Archive's recorded SHA-1, and the re-packed upload unpacks to identical files, modes and symlinks.

Workflows

• Removed Release.yml. It posted to upstream's Discord and bumped the Whisky-App Homebrew cask, and it ran on every published release, including the runtime release.
• CI now runs swift test for WhiskyKit.

Testing

• New WhiskyKit tests: log capping and pruning, download validation, staged install and rollback, process stream completion, children holding pipes open, and an idle-CPU regression test. 15 tests pass.
• SwiftLint --strict is clean, and the Whisky and WhiskyCmd schemes build with no warnings.
• Not tested in the running app yet: first-run setup with the published runtime, and creating a bottle.

Not fixed here

• Steam won't start (Steam won't open [Bug]:  Whisky-App/Whisky#946, Steam won't open. Whisky-App/Whisky#1338, macOS 15.4.1 breaks Steam Whisky-App/Whisky#1372). The runtime is Wine 7.7, and current Steam needs a newer Wine build. The community workarounds (downgrading to archived Steam builds, or switching the bottle to Windows 8.1) aren't included, because of security issues in old Steam builds and Steam ending Windows 8.1 support.
• Crash on launch ([Bug]: Application Crash on Launch Whisky-App/Whisky#1131, Latest Whisky update crashes on launch (V. 2.3.3) on M1 Pro 16 inch (GPTK 1.1) Sequoia Whisky-App/Whisky#1159). Not reproduced. The update check named in the crash reports was rewritten, but I can't confirm the crash is gone.

For reviewers

• Info.plist still points Sparkle at upstream's appcast (data.getwhisky.app/appcast.xml), so this build would be offered upstream's app updates.
• New strings are English only.