Repository navigation
Point at iStorry/Brandy and fix CI's stale package cache - #5
Merged
Merged
Conversation
The repository is now iStorry/Brandy. The runtime download URL, update feed, Help menu link, README badge and publish script use the new name. GitHub redirects the old URLs, so earlier builds keep downloading the runtime. CI on main failed with "There is no XCFramework found at .build/SourcePackages/artifacts/sparkle/Sparkle/Sparkle.xcframework": the restored package cache had checkouts but not Sparkle's binary artifact, and neither -disableAutomaticPackageResolution nor an explicit resolve downloads a missing artifact once packages count as resolved, so the bad cache failed every build. CI now caches only the Git mirrors under a new key; checkouts and artifacts are recreated each run at the versions pinned in Package.resolved. Reproduced locally by deleting the artifact, then built successfully from the Git mirrors alone.
The snifter icon read as flat clip art. The new icon, Strata, shows five flowing bands rising from deep wine to gold under a glowing sun: brandy distilled from wine. scripts/generate-app-icon.swift draws it in Core Graphics and writes every size the app icon set needs, the Quick Look thumbnail badge (which still showed the old Whisky icon) and the README image.
CI's lint step failed on scripts/generate-app-icon.swift: it lacked the project's license header, used one-letter variable names, had lines over 120 characters and called Void functions from ternaries. Add the header, name the superellipse and wave coordinates, wrap the long lines and use if/else. All twelve rendered PNGs are byte-for-byte identical before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Repository rename
scripts/publish-whiskywine.shCI's stale package cache
mainfailed after Brandy: one-click Steam on Wine 11, modern UI, rebrand and audit fixes #4 with "There is no XCFramework found at .build/SourcePackages/artifacts/sparkle/Sparkle/Sparkle.xcframework".-disableAutomaticPackageResolutionnor an explicit resolve downloads a missing artifact, so the bad cache failed every build..build/SourcePackages/repositories(the Git mirrors) under a new key. Checkouts and artifacts are recreated each run, at the versions pinned inPackage.resolved(-onlyUsePackageVersionsFromResolvedFile).Testing
--strict, the 36 WhiskyKit tests, and Release builds of Whisky and WhiskyCmd all pass.