Repository navigation
Release Brandy 1.0.1 - #7
Merged
Merged
Conversation
Steam setup: the first update started Steam with -noverifyfiles, which skips the check that makes Steam download its client, so it failed with "Failed to load steamui.dll". The flag is now only passed once the first update is done, and setup fails with a retry if Steam exits mid-update instead of waiting forever. Bottle deletion: deleting reused the creating flag, and reloading kept bottles in creation that weren't in the saved list, so a deleted bottle stayed in the sidebar as "Creating…". Bottles now have a creating, moving or deleting activity, and deletion stops the bottle's programs and removes the folder off the main thread. Pins: setup pinned steam.exe while the Start Menu pinned Steam.exe. Pins now compare paths case-insensitively, and existing duplicates collapse on load. The Steam pin opens through the single Steam session, and pins show when their program is running. D3D11 games: DXVK is on by default and setup turns it on for the Steam bottle; without it Unity games failed with "Failed to initialize graphics".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while testing 1.0.0, and the version set to 1.0.1 (45).
-noverifyfiles, which skips the check that makes Steam download its client, so setup failed with "Failed to load steamui.dll" and then waited forever. The flag is now only passed after the first update, and setup fails with Retry if Steam exits mid-update.steam.exe, the Start Menu pinnedSteam.exe. Pins now compare paths case-insensitively and existing duplicates collapse on load. The Steam pin opens through the single Steam session, and pins show when their program is running.Tested by hand on an M2 Pro: Steam setup from scratch, deleting the Steam bottle, the Steam pin, and R.E.P.O. launching with DXVK.
swift test(39 tests), SwiftLint and both release builds pass.