Repository navigation
Trim custom persona replies too, without re-sampling their openings - #259
Merged
Merged
Conversation
A short persona like «Ученица и помощник» kept the whole reaction frame because custom personas skipped the review. The frame is cut for them as well; only the repeated-opening re-sample stays off, since a persona may keep a fixed opening of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#258 skipped the reply review for every chat with a custom persona. After the deploy, a private chat with the persona «Ученица и помощник» (1862 chats have a custom persona) kept delivering «Ха-ха, ну ты и …! 😂» openers untouched.
Change
review_reply_shapenow reviews custom persona replies as well: the reaction opener, read-back quotes and an unstarted generation promise are cut. Only the repeated-opening re-sample stays off for them, because a persona may keep a fixed opening of its own (for example a role-play «(я чувствую, как…» frame).Measurement
On 469 production replies with a custom persona: 106 trimmed, 363 kept, 0 re-sampled. A read of 15 random trimmed replies found the meaning intact.
Checks
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test -p openplotva-llm(newchat_step_trims_but_never_resamples_a_custom_persona_reply)