Repository navigation
Start replies with the substance; deliver text beside a lone reaction - #261
Merged
Merged
Conversation
Prompt changes chosen by an A/B replay of production dialog requests: - The last-message note asks for a text reply that starts with the substance and lists the openings of the bot's last eight replies to avoid (none for a custom persona). - shared_core: no name or greeting up front, no lead-in, agreement or acknowledgment before the point, past replies are context and not a template, explicit translation requests always go through translate_text. - system_contract: native tool calls first, no report of the tool call before the answer. - draw_image and generate_song no longer suggest text beside the call. - The repeated-opening re-sample note asks for a different first sentence without quoting the rejected one. Replay (131 history + 20 tool requests): short intro sentence 39% -> 22%, reaction openers 11% -> 8%, repeated opening 3.1% -> 1.6%, native tool calls 8 -> 12 of 20, executable calls unchanged at 19 of 20. The new re-sample note repeats the rejected opening in 1 of 16 cases instead of 7. Text the model returns together with react_to_message alone is now the final reply: the session delivers it without asking the model again.
Owner
Author
|
Danger prompt warning: the prompt changes are intentional and keep the existing shape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
translate_text.react_to_message.turn_boundaryandtool_contractstate the reaction exception.draw_imageandgenerate_songno longer suggest text beside the call; the session never published that text.react_to_messagesays that text returned with it is delivered.react_to_messagealone is the final reply. The session delivers it without a second model call. The text passes the same leak guard and reply-shape review as any final answer. Text beside any other tool call is still dropped.Prompt replay
The replay used 131 production requests without tool calls and 20 requests with tool calls, all with untrimmed history. The new prompt was compared with the deployed one.
On the 16 replies whose opening repeated a recent one, the re-sample started the same way in 7 cases with the old note. With the new note it did so in 1 case.
Checks
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test -p openplotva-dialog -p openplotva-llm -p openplotva-prompts -p openplotva-app