Repository navigation
Report SAFE run_python files under sent, like a real delivery - #272
Merged
Merged
Conversation
After #271 the SAFE result said the chat received the chart, but its data still carried send_withheld. Gemma read that as unfinished work and called a nonexistent send_files tool twice before the turn fell back to Qwen. A withheld delivery now fills sent exactly as a real one does; tool_mode SAFE already tells operators that nothing left the sandbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #271, the production SAFE virtual dialog produced a clean reply ("Готово, вот диаграмма."), but only through the fallback model. The tool result said "the chat received sales_chart.png", while its data still listed the file as
send_withheld. Gemma read that field as unfinished work and called a nonexistentsend_filestool twice ({"file_ids":["sales_chart.png"]}). The turn then fell back to Qwen.Real deliveries report the files under
sent, so SAFE mode did not show the model what it sees in a real chat.Change
withhold_deliveryruns fillsentexactly as a real delivery does; thesend_withheldfield is gone. Thetool_mode: "SAFE"marker, which the SAFE toolbox adds, already tells operators that nothing left the sandbox. This follows the other SAFE tools:draw_apireportsdelivered: true.The English chart labels in the earlier test runs come from the virtual dialog's debug user, whose context carries
<locale>en</locale>. They are not a model error.Verification
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p openplotva-app(1434 passed),-p openplotva-dialog(106)After the deploy, the production SAFE virtual dialog will repeat the chart request and a follow-up edit.
Deployment risk
Only SAFE runtime virtual dialogs change; real chats are unaffected. Rollback: revert this commit.