Repository navigation
Use native argument forwarding in resource services (5.0.3) - #21
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
jlsync
force-pushed
the
codex/resource-service-forwarding
branch
from
November 6, 2026 22:20
1c66f65 to
0a62d2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource service proxies capture and repack positional arguments, keywords, and blocks on each delegated call. Use Ruby’s native
...forwarding inResourceService#method_missing,#find,#new, andSingletonResourceService#newto reduce temporary allocations while preserving custom finders and association routing. Leavedestroyunchanged to preserve its existing block handling.Add nine focused regression tests covering positional hashes, keyword and block forwarding, calls without keywords or blocks, and both custom finder forms. Bump
rc_railsto 5.0.3 and add a brief changelog entry.Validation:
bundle exec rspec— 685 examples, 0 failures on Ruby 4.0.9 / Rails 8.1.4;git diff --checkpasses. Allocation measurements were made on Ruby 4.0.9; gains may vary on other supported Ruby versions.