IBX-12285: Rendered the input's extra button as a DS secondary button - #2032
Open
tischsoic wants to merge 3 commits into
Open
IBX-12285: Rendered the input's extra button as a DS secondary button#2032tischsoic wants to merge 3 commits into
tischsoic wants to merge 3 commits into
Conversation
dew326
approved these changes
Aug 26, 2026
albozek
approved these changes
Aug 26, 2026
katarzynazawada
force-pushed
the
IBX-12285-misaligned-add-button
branch
from
August 27, 2026 09:35
345d7f9 to
69f7657
Compare
katarzynazawada
requested changes
Aug 27, 2026
katarzynazawada
left a comment
katarzynazawada
left a comment
Contributor
There was a problem hiding this comment.
Please align with design from https://www.figma.com/design/4sbNQyNLhFFwxWDH89Rf9X/🟢--Ibexa--Design-System?node-id=8984-162879&p=f&t=uLTZXphcPkv74gMx-0
tischsoic
changed the title
… path Co-authored-by: Claude <noreply@anthropic.com>
Use the <twig:ibexa:button> tag form with a spread props hash instead of the component() function, and drop the legacy ibexa-btn markup from the non-DS fallback so both paths emit the same DS button. Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
katarzynazawada
force-pushed
the
IBX-12285-misaligned-add-button
branch
from
August 28, 2026 11:29
fd5aab1 to
5ae77ea
Compare
|
katarzynazawada
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
input_text_ds.html.twigbuilt theextra_btnclasses once, before the template branches, so the DS render path got a legacybtn ibexa-btn ibexa-btn--infobutton — 48px tall inside the DS input's 40px actions row, overflowing the frame.The extra button is now a DS button in both branches,
secondaryat the default medium size, matching the design and the samesecondarytreatment the legacyinput_text.html.twigalready uses.The only consumers of
extra_btnthrough this template are the Product collection and Product embed blocks in ibexa/product-catalog.For QA:
Page Builder → Product collection or Product embed block → Properties: the Add button in the product code input should be a full-height, purple-outlined button flush with the input's right edge.
Inputs that use this template without an extra button (global search, login form, Content Type field-type search) should be unchanged.
Documentation: