IBX-12188: Replaced legacy alerts and notifications with the design-system Alert - #2034
Open
tischsoic wants to merge 5 commits into
Open
IBX-12188: Replaced legacy alerts and notifications with the design-system Alert#2034tischsoic wants to merge 5 commits into
tischsoic wants to merge 5 commits into
Conversation
…ystem Alert Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 26, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
tischsoic
commented
Aug 27, 2026
Comment on lines
+3
to
+4
| // Transitional: keeps the spacing legacy `alert.html.twig` call sites got from Bootstrap's `.alert` margin. | ||
| // Goes away together with the adapter template. |
Contributor
Author
There was a problem hiding this comment.
change these comments into TODO: comment
tischsoic
commented
Aug 27, 2026
Comment on lines
+1
to
+6
| {# | ||
| Compatibility wrapper around the design-system <twig:ibexa:alert> component, kept for the | ||
| existing `include`/`embed` call sites. New code should use <twig:ibexa:alert> directly. | ||
| Legacy params `size`, `show_subtitle_below` and `attr` are ignored; the `title` block is gone (title is a plain string prop). | ||
| Inline renders get `ibexa-alert-adapter`, which restores the bottom margin Bootstrap's `.alert` used to add. | ||
| #} |
Contributor
Author
There was a problem hiding this comment.
Change into TODO comment
dew326
approved these changes
Aug 28, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
…helper.js Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Contains a TEMPORARY
dependencies.jsoncommit pinningdesign-system-twig + admin-ui-assets (IBX-12188-alert-component)for browser tests. Remove that commit and theibexa/admin-ui-assetsIBX-12188-alert-component[TMP] branch before merging.Related PRs:
Description:
Legacy alerts and toast notifications now render the design-system Alert:
ui/component/alert/alert.html.twigandui-dev/.../common/alert/alert.jsare deprecated adapters over<twig:ibexa:alert>/@ids-components/components/Alert— the existinginclude/embedcall sites across packages keep working (size,show_subtitle_below,attrand thetitleblock are no longer supported). Inline renders getibexa-alert-adapterfor the bottom margin Bootstrap's.alertused to add.notification.html.twigis rendered once per type intodata-template-<type>;admin.notifications.js/admin.error.page.jsinitialise the DS Alert behaviour on each toast and dismiss through it (no BootstrapAlert).ibexa.helpers.notification.*API unchanged._alerts.scssremoved; onlyids-alert*classes remain (Behat locators and the invitation-modal JS updated).Merge order: after design-system + design-system-twig (and an admin-ui-assets bump to a design-system build containing
Alert).For QA:
Login with wrong credentials (inline error alert); publish content (success toast auto-closes after 5 s, error toasts stay until closed); reset-password confirmation; user invitation modal warnings (close hides them); Content type edit "non-translatable fields" warning.
Documentation:
Legacy
alert.html.twigparamssize,show_subtitle_below,attrand thetitleblock are dropped; new code should use<twig:ibexa:alert>.