IBX-12322: Harmonized container shadows on the design-system token - #2037
Open
tischsoic wants to merge 2 commits into
Open
IBX-12322: Harmonized container shadows on the design-system token#2037tischsoic wants to merge 2 commits into
tischsoic wants to merge 2 commits into
Conversation
The Design System specifies the container shadow at 10% opacity, so point $ibexa-edit-header-box-shadow at $box-shadow-medium instead of $box-shadow-large (15%). Co-Authored-By: Claude <noreply@anthropic.com>
Container surfaces each hard-coded their own copy of the 4/22/47 shadow with a different colour and alpha, so .ibexa-tab-content rendered a blue shadow next to .ibexa-container's neutral one. Add $ibexa-container-box-shadow, sourced from the DS $box-shadow-medium, and use it for the container surfaces. It lives in the alias layer so other packages reach it through the custom.scss they already @use, with no new imports. $ibexa-edit-header-box-shadow is left alone — its other consumers are floating/transient elements, not containers. Also drop three declarations with no remaining call sites: $ibexa-context-menu-box-shadow and the container-box-shadow / container-box-shadow-right mixins. container-box-shadow-left stays; it is still included by _extra-actions.scss. Co-Authored-By: Claude <noreply@anthropic.com>
|
albozek
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/design-systemmust merge first —admin-ui-assetspins the design system as#main, so this change only renders once the design-system PR has landed and been rolled intoadmin-ui-assets.Description:
Container surfaces each hard-coded their own copy of the
4px 22px 47pxshadow with a different colour and alpha, so.ibexa-tab-contentrendered a blue shadow right next to.ibexa-container's.Adds
$ibexa-container-box-shadow, sourced from the design-system$box-shadow-medium(#CFD0D0@ 10%), and uses it for the container surfaces:.ibexa-container,.ibexa-tab-content,.ibexa-adaptive-filters,.ibexa-collapse--heavyand the UDW search top bar. It lives in the alias layer, so the other packages reach it through thecustom.scssthey already@use— no new imports anywhere.$ibexa-edit-header-box-shadowis deliberately kept: its remaining consumers are floating/transient (chart, back-to-top, Page Builder timeline and tooltips), not containers, so renaming it would be a BC break and would mislabel them.Also drops three declarations with no call sites left —
$ibexa-context-menu-box-shadowand thecontainer-box-shadow/container-box-shadow-rightmixins.container-box-shadow-leftstays;_extra-actions.scssstill includes it.Tooltips, popovers, dropdowns, drag-hover lifts, edge shadows and repeated list/grid items keep their current shadows — harmonizing those is IBX-12222.
For QA:
The new shadow is deliberately very subtle:
#CFD0D0at 10% composites to roughly#FAFAFAon white, so it reads as a faint lift rather than the previous purple glow. Please don't report the faintness as a bug./admin/role/listand/admin/product/list— container and filter panel/admin/view/content/<id>/full/<version>/<location>— tab content, now the same shadow as the container above itDocumentation: