Use PHP Behat configuration as behat.php when the edition ships one - #145
Open
ViniTou wants to merge 5 commits into
Open
Use PHP Behat configuration as behat.php when the edition ships one#145ViniTou wants to merge 5 commits into
ViniTou wants to merge 5 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Behat 4 drops YAML configuration;
ibexa/behat6.0 shipsbehat_ibexa_<edition>.phpnext to the YAML files (ibexa/behat#195) and the 6.0 recipe copies both to the project root (ibexa/recipes-dev#258). The 6.0.x-dev and stable prepare scripts now copy the.phpfile tobehat.phpwhen it exists and fall back tobehat.yamlotherwise, so older versions are unaffected.Behat's auto-discovery prefers every YAML candidate (
behat.yaml,behat.yml.dist, …) overbehat.php, and thefriends-of-behat/symfony-extensionFlex recipe leaves abehat.yml.distin the project root, which then silently wins. The scripts therefore remove all discovery candidates before copying the edition file.Also fixes a pre-existing bash syntax error in both scripts (
elif [[ ... ]] thenwithout;, rejected bybash -n).For QA:
CI only. Verified via ibexa/behat#195 with
ci-scripts-branch: behat-php-config.Documentation:
N/A