Skip to content

[TMP] Run regression for IBX-12043 (DBAL 4) - #1922

Open
ViniTou wants to merge 13 commits into
6.0from
ibx-12043-dbal4-regression
Open

[TMP] Run regression for IBX-12043 (DBAL 4)#1922
ViniTou wants to merge 13 commits into
6.0from
ibx-12043-dbal4-regression

Conversation

@ViniTou

@ViniTou ViniTou commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

ibexa/core#800
ibexa/core-persistence#39
ibexa/doctrine-schema#45
https://github.com/ibexa/installer/pull/217
ibexa/doctrine-migrations#6
https://github.com/ibexa/migrations/pull/447
https://github.com/ibexa/taxonomy/pull/438
https://github.com/ibexa/product-catalog/pull/1563
https://github.com/ibexa/fieldtype-page/pull/218
https://github.com/ibexa/connector-payum/pull/44
https://github.com/ibexa/measurement/pull/141
https://github.com/ibexa/workflow/pull/202
ibexa/system-info#90
https://github.com/ibexa/discounts/pull/352
https://github.com/ibexa/site-factory/pull/185
https://github.com/ibexa/order-management/pull/196
https://github.com/ibexa/page-builder/pull/581
ibexa/fieldtype-matrix#100
https://github.com/ibexa/shopping-list/pull/68
https://github.com/ibexa/site-context/pull/149
ibexa/user#138
https://github.com/ibexa/discounts-codes/pull/54
https://github.com/ibexa/activity-log/pull/175
https://github.com/ibexa/collaboration/pull/119

Not listed, deliberately:

Each package is flagged shouldBeAddedAsVCS so Composer resolves the branch straight from GitHub. Satis lagged behind a force push more than once while this work was in progress, and a regression run silently resolving a stale commit is worse than a slower one.

What this build is expected to catch that the package pipelines cannot:

  • The per-package Browser tests jobs fail across the set with Your requirements could not be resolved, because an inline alias only applies in the root package and ibexa/oss pulls these transitively at ~6.0.x-dev. Here the branches are added to the project's own require, so the alias holds and the stack resolves as one.
  • MariaDB. No package pipeline in the organisation runs it, and DBAL 4 reparents MariaDBPlatform off MySQLPlatform, which already broke the Random sort clause once during this work. Setup 2 covers MariaDB 11.4.
  • A real installation rather than a test fixture: schema generated by the installer, on MySQL 8.4, MariaDB 11.4 and PostgreSQL 18, with Solr and Elasticsearch.

Databases are created fresh here, so this exercises the new utf8mb4_unicode_520_ci DDL rather than the upgrade path. Converting an existing database is a separate procedure — two console commands plus the SQL script in ibexa/installer — and is not covered by this run.

ViniTou added 2 commits August 7, 2026 14:32
Points the commerce regression build at the DBAL 4 branches of the ten packages the edition installs. Revert once they are merged.
Composer authenticates against github.com for every VCS repository it is given, and adding one for a public package broke that with "Could not authenticate against github.com". The public ones resolve without it.
@ViniTou
ViniTou force-pushed the ibx-12043-dbal4-regression branch from 8200dcd to a9532ef Compare August 7, 2026 12:46
@ViniTou
ViniTou force-pushed the ibx-12043-dbal4-regression branch from 2f99669 to a9532ef Compare August 18, 2026 07:56
Its attribute visitor narrowed a return type the DBAL 4 parent widened, which fataled at class load. Private repository, so it needs a VCS entry.
Its gateway passed composite expressions to leftJoin, which DBAL 4 rejects; three of those were hidden behind a PHPStan baseline. Private repository, so it needs a VCS entry.
All three broke on DBAL 4 in the previous run: a moved class, an array passed to a variadic select, and integers handed to a string-only expression builder.
The satis pipeline serves them, and the GitHub App token composer is given cannot clone over git, so every VCS entry fails on the first repository composer tries.
It is not part of a Commerce install, and forcing it in leaves league_oauth2_server without its required authorization_server configuration, so the project cannot build its container.
@bnowak

bnowak commented Aug 28, 2026

Copy link
Copy Markdown

in browser tests (beside of timeouts) I can spot some failing tests, like:

Then I should see a Base price with "12.00 $" value         # Ibexa\ProductCatalog\Behat\Context\ProductsContext::iVerifyBasePrice()
      Webmozart\Assert\InvalidArgumentException: Failed asserting that expected string '12.00 $' is equal to actual '12.00 US$' for css locator 'basePricePreview': '.ibexa-pc-product-prices__main-price .ibexa-pc-product-item-preview__value' in vendor/webmozart/assert/src/Assert.php:2604
And I set product attributes                                                          # Ibexa\ProductCatalog\Behat\Context\ProductsContext::iSetAttributes()
      | label | value | attributeType |
      | Year  | 2026  | datetime      |
      RuntimeException: Field Year not found. Found:  in vendor/ibexa/admin-ui/src/lib/Behat/Page/ContentUpdateItemPage.php:201

Are they dbal update-related? or some independent product-catalog topics?

anyway, if would be nice to have full regression set pass in the end before merging 😉

@ViniTou

ViniTou commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

@bnowak
those are either failing on main branch as well, or single PR needs rebased after the fix. I'm waiting for 6.0 to lit green before restart as it dosent make sense otherwise.

(those were failing at 6.0 at the time creating this as well, for now, only the selector one is failing afaik).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants