IBX-12374: Convert Behat annotations to attributes and add PHP suite configuration - #812
Open
ViniTou wants to merge 2 commits into
Open
IBX-12374: Convert Behat annotations to attributes and add PHP suite configuration#812ViniTou wants to merge 2 commits into
ViniTou wants to merge 2 commits into
Conversation
|
Steveb-p
reviewed
Aug 28, 2026
| * Makes sure a content type with $identifier and with the provided $fields definition. | ||
| */ | ||
| #[Given('(that) a content type exists with identifier :identifier with fields:')] | ||
| #[Given('(that) a content type exists with identifier :identifier in Group with identifier :groupIdentifier with fields:')] |
Contributor
There was a problem hiding this comment.
Is this correct? It's supposed to be a data table.
Contributor
Author
There was a problem hiding this comment.
it is, that table definition was never part of step definition, it serves only as documentation - actual table stil sits in TableNode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Part of the Behat 4 upgrade. Behat 4 removes docblock annotations (
@Given/@When/@Then) and YAML configuration; the Behat 3.32 already installed accepts PHP attributes and PHP config, so this converts the bundle ahead of theibexa/behatswitch without changing behaviour. Every bundle with Behat contexts gets the same treatment independently.The 65 annotations were converted by Rector (
->withAttributesSets(behat: true), now enabled inrector.php, so new annotations fail the rector CI job); Behat 4 also requires explicit parameter/return types on step methods, added where missing.behat_suites.phpis the--convert-configoutput ofbehat_suites.yml; the YAML file stays untilibexa/behatimports the PHP one, because the root config references it by filename and the two packages' versions drift within an app.For QA:
No functional change to the scenarios; same suites run. Any phpstan/phpunit failures on this branch are pre-existing on
6.0with the local vendor state; nothing was baselined.Documentation:
N/A