IBX-12358: Introduced Bootstrapper / Hooks for integration tests - #234
Open
Steveb-p wants to merge 4 commits into
Open
IBX-12358: Introduced Bootstrapper / Hooks for integration tests#234Steveb-p wants to merge 4 commits into
Steveb-p wants to merge 4 commits into
Conversation
Replaces the hand-rolled bootstrap.php with ibexa/test-core's shared
Bootstrapper, registering IbexaTestCoreBundle in the test kernel and
running the Bootstrapper/hooks in place of the manual kernel boot.
Database preparation and the schema/fixture hooks are disabled, matching
the original script's own documented intent ("Skipping database
initialization until really needed by integration tests") since this
suite boots the kernel only and never touches a database.
The console Application object the old script built was dead code (built
and never used before kernel shutdown), so it is dropped rather than
preserved.
Points CI at the branch that adds the Bootstrapper/hooks, so this PR's tests can run before that PR merges. Must be removed before merging.
Steveb-p
marked this pull request as ready for review
August 26, 2026 13:46
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
August 26, 2026 13:46
bnowak
approved these changes
Aug 27, 2026
Same root cause as the other packages fixed in this rollout: pinned to a stale ~0.1.x-dev constraint that predates the versioning scheme used everywhere else, masked for the duration of the rollout by the (now-removed) dependencies.json override. Bumping to ~4.6.x-dev, matching every other package here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Swaps the hand-rolled
tests/integration/bootstrap.phpforibexa/test-core's newBootstrapper, and registersIbexaTestCoreBundleintests/integration/IbexaTestKernel.phpright afterparent::registerBundles().Bootstrapper::OPTION_PREPARE_DATABASEis set tofalse, with bothDatabaseSchemaHookandFixtureHookdisabled. That matches what the old script was already telling us — it built the kernel, built a consoleApplicationand immediately shut down again, with a comment saying "Skipping database initialization until really needed by integration tests". So there was never a DB step to replace here, this suite only needs the kernel booted. TheApplicationobject itself wasn't used for anything either (no command ever ran against it), so I dropped it rather than carrying it over as dead code.IbexaTestKerneldidn't have anygetSchemaFiles()/getFixtures()/getMigrationFiles()overrides to worry about, and there's noIbexaKernelTestTraitusage in this repo either, so the conversion is pretty mechanical.For QA:
Not applicable.
Verification:
ibexa/test-core's4.6.x-devbranch alias resolved fine viadependencies.json(no need to fall back to the^0.1.x-devconstraint currently incomposer.json) —composer installpicked upibexa/test-core (dev-kernel-test-bootstrap-v2 e90c557)cleanly.composer.jsonrestored byte-identical after thedependencies.jsondry-run/real run (confirmed viagit diff).composer test-integration: 17 tests, 28 assertions, all green. Novar/test.dbor any other SQLite file got created.composer phpstan: no errors.composer check-cs: clean, no changes needed.