IBX-12358: Introduced Bootstrapper / Hooks for integration tests - #139
Merged
Conversation
tests/bootstrap.php was a plain kernel boot + doctrine:database:create +
schema/fixture import loop. Collapsed to (new Bootstrapper())->bootstrap().
- tests/integration/IbexaTestKernel.php:
- Now extends ibexa/test-core's IbexaTestKernel, not ibexa/core's own
legacy Ibexa\Contracts\Core\Test\IbexaTestKernel it extended before -
the Bootstrapper mechanism requires the former.
- Registers IbexaTestCoreBundle itself.
- getSchemaFiles() is gone, replaced by UserSchemaFilesProvider, a
tagged provider service that constructor-injects test-core's
DefaultSchemaFilesProvider to add this package's own schema file on
top of the built-in default. No fixture override existed before
(this package relies entirely on the built-in base fixture), so
nothing to convert there.
- New tests/integration/Resources/services.php: declares the schema
provider as a tagged service.
- Added ibexa/test-core to require-dev (wasn't required at all before).
Verified: real schema/fixture import (55 tables, 18 content objects in
the resulting database), 9 integration + 57 bundle/lib tests pass,
PHPStan and cs-fixer clean.
Points CI at the branch that adds Bootstrapper, so this PR's tests can run before that PR merges. Must be removed before merging.
Steveb-p
changed the title
Steveb-p
marked this pull request as ready for review
August 26, 2026 13:47
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
August 26, 2026 13:47
bnowak
approved these changes
Aug 27, 2026
ViniTou
approved these changes
Aug 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Fifth rollout sample, picked as a "kernel-method-style provider" case (bucket 2): the old
tests/bootstrap.phpwas a plain kernel boot,doctrine:database:create, and schema/fixture importloop, no migrations or bespoke extras.
tests/bootstrap.php: collapsed to(new Bootstrapper())->bootstrap();.tests/integration/IbexaTestKernel.php:ibexa/test-core'sIbexaTestKernel, notibexa/core's own legacyIbexa\Contracts\Core\Test\IbexaTestKernelit extended before - the Bootstrapper mechanismrequires the former.
IbexaTestCoreBundleitself.getSchemaFiles()is gone, replaced byUserSchemaFilesProvider, a tagged provider servicethat constructor-injects
ibexa/test-core'sDefaultSchemaFilesProviderto add this package'sown schema file on top of the built-in default. No fixture override existed before (this
package relies entirely on the built-in base fixture), so nothing to convert there.
tests/integration/Resources/services.php: declares the schema provider as a tagged service.ibexa/test-coretorequire-dev(wasn't required at all before).For QA:
Not applicable - test infrastructure only, no runtime behavior change.
Verified locally: real schema/fixture import (55 tables, 18 content objects in the resulting
database), 9 integration + 57 bundle/lib tests pass, PHPStan and cs-fixer clean.