Retry shadow.data copy and keep the PVC if it fails - #406
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
radiken
changed the title
radiken
marked this pull request as ready for review
September 19, 2026 00:30
AlbertoSoutullo
requested changes
Sep 21, 2026
AlbertoSoutullo
left a comment
AlbertoSoutullo
left a comment
Collaborator
There was a problem hiding this comment.
pull_shadow_logs() is synchronous, but it is called directly from the async _run() method. During every retry interval, time.sleep(60) blocks the event loop so a failed copy can stall the entire experiment process for up to an hour.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
AlbertoSoutullo
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
kubectl cpof shadow.data fails, the run retries it every 60 s for up to an hour. If it still fails, cleanup leaves the PVC in place so the data can be copied by hand, instead of deleting it with the run.Related to #319