Skip to content

ci: add nim code compile check - #57

Merged
vladopajic merged 2 commits into
masterfrom
ci-compile-test
Sep 22, 2026
Merged

vladopajic merged 2 commits into
masterfrom
ci-compile-test

Conversation

@vladopajic

@vladopajic vladopajic commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

simple ci that will check if nim node source is successfully compiled.

@vladopajic

Copy link
Copy Markdown
Contributor Author
image

@AlbertoSoutullo would be cool to have these checks as mandatory, so these have to pass before merging pr

@AlbertoSoutullo

Copy link
Copy Markdown
Collaborator

@AlbertoSoutullo would be cool to have these checks as mandatory, so these have to pass before merging pr

Hmm how much time it takes? I don't know if I am fully convinced. First of all because we will need to increase this if we add more test nodes. Checking the compilation of all of them when we are only modifying one feels like a waste of time.
Then, on top of it, its not the first time that something compiles perfectly locally, and then I try to create a docker image with the 2.2.10 nim base image and the build fails...

So I don't know if this is really adding value. Ideally before we add a new version, we have to create images for that and update the README adding the links, so I don't think this is saving much... What do you think?

@vladopajic

vladopajic commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

usage:
https://github.com/vacp2p/dst-libp2p-test-node/actions/runs/35722106085/usage

compiles perfectly locally

this is isolated ci, if it compiles in ci, itl should compile in docker image - if all things are equal. but building docker image could also be done.

really adding value

i was thinking of having this as something until there is some kind of some test for nodes. smoke test would give more benefit then compile, but i just added this as simple ci for start

@AlbertoSoutullo

Copy link
Copy Markdown
Collaborator

this is isolated ci, if it compiles in ci, itl should compile in docker image - if all things are equal. but building docker image could also be done.

I can already tell you that this is not the case haha. But ok lets add this.

@vladopajic
vladopajic merged commit e674a60 into master Sep 22, 2026
6 checks passed
@vladopajic
vladopajic deleted the ci-compile-test branch September 22, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants