Refactor selectlist attach feature#175
Open
LionelZoubritzky-IGN wants to merge 2 commits into
Open
Conversation
LionelZoubritzky-IGN
added this to the
v0.10.x MCP and WFS Stabilization to improve reliability milestone
LionelZoubritzky-IGN
added
refactoring
LionelZoubritzky-IGN
force-pushed
the
refactor-selectlist-attachFeature
branch
from
July 23, 2026 09:45
e55fafe to
fc26169
Compare
LionelZoubritzky-IGN
force-pushed
the
refactor-selectlist-attachFeature
branch
from
July 24, 2026 13:08
fc26169 to
d74b22b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two code inconsistencies:
select: one exists for the GpfGetFeatures codepath and another for GpfGetFeatureById, while they should be identical.attachFeatureRefsintopostProcessFeatureCollectionto more accurately reflect that this function handles all the post-processing, and does not only attach feature refs anymore.Pure refactors, no impact on behavior.