Repository navigation
refactor(ui): drop leftover button class overrides (phase C) - #90
Merged
Merged
Conversation
Phase A/B moved every call site onto the button system, but some buttons still overrode height, radius, padding or colours through className, which bypasses the 44px touch sizing and the per-role look. - QuickTask submit uses size="lg" instead of h-11 (input matches it). - Archive purge uses variant="danger-ghost" instead of text-destructive. - Block-type picker marks the active type with variant="secondary" instead of a bg-accent override. - New icon-xs size (16px round, tap-area) for the tag chip remover. - link buttons drop side padding via a compound variant, so call sites no longer need px-0. - Removed padding/hover-colour overrides in Kanban, DemoBanner, CommandMenu, FillFromText, BlockEditor, TaskFilters, calendar, notes, the app shell and login. - AGENTS.md: className on Button is for layout only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Asserts that link buttons drop side padding while keeping their height and tap area, and that the new icon-xs size stays round with a 44px hit area on touch screens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ilramdhan
marked this pull request as ready for review
October 8, 2026 08:13
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase C of the button system (after #87 and #88). Some
Button/IconButtoncall sites still overrode height, radius, padding or colours throughclassName, which bypasses the 44px touch sizing and the one-look-per-role rule. This PR removes those overrides and picks the rightvariant/sizeinstead.QuickTasksubmit:size="lg"instead ofh-11(the input ish-10 coarse:h-11so the row stays aligned and still grows to 44px on touch).variant="danger-ghost"instead oftertiary+text-destructive hover:text-destructive.variant="secondary"instead of abg-accentoverride;px-2dropped.icon-xs(16px, round,tap-area) for the tag chip remover inTagInput, replacingsize-4 rounded-full hover:bg-background/70 [&_svg]:size-3.linkbuttons now drop side padding via acompoundVariantsentry (sm/md/lg), so call sites no longer needpx-0.size-11+ amber hover), CommandMenu mode toggle, FillFromText, BlockEditor "add block", TaskFilters reset, TaskViews "show done", calendar "+N more", note properties, app shell (sign out, capture dialog links) and login (back link, forgot password).AGENTS.md: new bullet under the Buttons rule: don't override height/colour/radius/padding throughclassName; it is for layout only (plustext-muted-foregroundto quieten a tertiary/link action).Remaining
classNameon buttons is layout (w-full,ml-auto,shrink-0,justify-start, opacity reveal) ortext-muted-foreground/font-normal, which the new rule allows.Closes #
Type of change
feat– new featurefix– bug fixrefactor/perf– no behavior change / performancedocs/test/chore/ciHow to test
danger-ghost) with a red-tinted hover.Screenshots / recordings
Visual deltas are small (padding/hover tints); no screenshots captured from this agent session.
Checklist
bun run lint,bunx tsc --noEmitandbun run testpass locallybun run buildpasses (required for routing, server function or config changes)AGENTS.md(data hooks insrc/lib/data.ts, task edits viaTaskDialogProvider/useTaskActions,PageContainer, soft delete, …)drizzle/migrations/registered inmeta/_journal.json, RLS enabled with policies + grants,src/integrations/supabase/types.tsregenerated (n/a)*.server.ts/ server functions and are never exposed viaVITE_*ACCESSIBILITY.md)CHANGELOG.md; don't edit the changelog by hand)README.md,AGENTS.mdif an architecture rule changed)main(keep published history intact)Notes for reviewers
check-migrations,check-n8n.linkcompound variant changes everyvariant="link"button withsm/md/lgtopx-0; all existing ones already usedpx-0orsize="inline".icon-xsis a new size (the tag remover was the only call site needing it). The existingbutton.test.tsxcase that overridesh-12is kept: tailwind-merge still allows overrides, the rule is a convention.secondarylook (border + background) instead of a plain accent fill.🤖 Generated with Claude Code