Skip to content

Develop #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexxtaurus83 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Develop #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a58a764
Fix obsolete GetInstanceID warning and duplicate ReleaseHandleOnDestr…
alexxtaurus83 Jun 30, 2026
f3376c3
package update
alexxtaurus83 Jun 30, 2026
f7ac58a
fix
alexxtaurus83 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Runtime/AddresssablesExtensions/LifetimeManagement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ private static ReleaseHandleOnDestroy AddAutoReleaseTrigger(AsyncOperationHandle
{
_ = targetGO ?? throw new ArgumentNullException(nameof(targetGO));

var trigger = targetGO.AddComponent<ReleaseHandleOnDestroy>();
var trigger = targetGO.GetComponent<ReleaseHandleOnDestroy>() ?? targetGO.AddComponent<ReleaseHandleOnDestroy>();

trigger.OnDestroyEvent += () => Addressables.Release(operationHandle);

Expand Down
8 changes: 4 additions & 4 deletions Runtime/ManageAddressables.BaseMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public static void Instantiate(AssetReference reference,
/// <param name="targetGO">The object to which the trigger will be attached.</param>
public static void AddAutoReleaseAssetTrigger(string key, GameObject targetGO)
{
targetGO.AddComponent<ReleaseHandleOnDestroy>().OnDestroyEvent +=
(targetGO.GetComponent<ReleaseHandleOnDestroy>() ?? targetGO.AddComponent<ReleaseHandleOnDestroy>()).OnDestroyEvent +=
() => ReleaseAsset(key);
}

Expand All @@ -248,7 +248,7 @@ public static void AddAutoReleaseAssetTrigger(string key, GameObject targetGO)
/// <param name="targetGO">The object to which the trigger will be attached.</param>
public static void AddAutoReleaseAssetTrigger(AssetReference assetReference, GameObject targetGO)
{
targetGO.AddComponent<ReleaseHandleOnDestroy>().OnDestroyEvent +=
(targetGO.GetComponent<ReleaseHandleOnDestroy>() ?? targetGO.AddComponent<ReleaseHandleOnDestroy>()).OnDestroyEvent +=
() => ReleaseAsset(assetReference);
}

Expand All @@ -261,7 +261,7 @@ public static void AddAutoReleaseAssetTrigger(AssetReference assetReference, Gam
/// <param name="targetGO">The object to which the trigger will be attached.</param>
public static void AddAutoReleaseInstanceTrigger(string key, GameObject targetGO)
{
targetGO.AddComponent<ReleaseHandleOnDestroy>().OnDestroyEvent +=
(targetGO.GetComponent<ReleaseHandleOnDestroy>() ?? targetGO.AddComponent<ReleaseHandleOnDestroy>()).OnDestroyEvent +=
() => ReleaseInstance(key, targetGO);
}

Expand All @@ -274,7 +274,7 @@ public static void AddAutoReleaseInstanceTrigger(string key, GameObject targetGO
/// <param name="targetGO">The object to which the trigger will be attached.</param>
public static void AddAutoReleaseInstanceTrigger(AssetReference assetReference, GameObject targetGO)
{
targetGO.AddComponent<ReleaseHandleOnDestroy>().OnDestroyEvent +=
(targetGO.GetComponent<ReleaseHandleOnDestroy>() ?? targetGO.AddComponent<ReleaseHandleOnDestroy>()).OnDestroyEvent +=
() => ReleaseInstance(assetReference, targetGO);
}
}
Expand Down
2 changes: 1 addition & 1 deletion Runtime/ManageAddressables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ private static void ReleaseInstanceInternal(string key, GameObject instance)
return;
}

var index = instanceList.FindIndex(x => x.GetInstanceID() == instance.GetInstanceID());
var index = instanceList.FindIndex(x => x == instance);

if (index < 0)
{
Expand Down
1 change: 1 addition & 0 deletions Runtime/ReleaseHandleOnDestroy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

namespace AddressablesMaster
{
[DisallowMultipleComponent]
public class ReleaseHandleOnDestroy : MonoBehaviour
{
public void OnDestroy()
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "com.inc8877.addressables-master",
"version": "1.0.2",
"version": "1.0.3",
"displayName": "AddressablesMaster",
"description": "Use Sync, Async(.NET / UniTask), Coroutine, Lifetime management tools for addressables assets with caching support",
"homepage": "https://github.com/inc8877/AddressablesMaster#readme",
Expand All @@ -18,7 +18,7 @@
"url": "https://github.com/inc8877/AddressablesMaster.git"
},
"dependencies": {
"com.unity.addressables": "1.6.0"
"com.unity.addressables": "2.9.1"
},
"author": {
"name": "Volodymyr Bozhko",
Expand Down