Same PG container in all tests - #743
Merged
Merged
Conversation
adamdickmeiss
requested review from
JanisSaldabols and
jakub-id
as code owners
August 31, 2026 08:50
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes PostgreSQL testcontainers on PostgreSQL 16 and increases the Directory integration-test startup timeout.
Changes:
- Pins all testcontainer images to
postgres:16. - Raises the Directory database startup timeout to 30 seconds.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
directory/test/00_integration_test.go |
Pins PostgreSQL 16 and extends startup timeout. |
broker/test/utils/utils.go |
Pins the shared test helper to PostgreSQL 16. |
broker/test/service/e2e_test.go |
Pins the E2E database image. |
broker/test/scheduler/service/scheduler_test.go |
Pins scheduler service tests. |
broker/test/scheduler/db/schedrepo_test.go |
Pins scheduler repository tests. |
broker/test/pullslip/api/api_handler_test.go |
Pins pull-slip API tests. |
broker/test/patron_request/db/prrepo_test.go |
Pins patron-request repository tests. |
broker/test/patron_request/api/api-handler_test.go |
Pins patron-request API tests. |
broker/test/handler/iso18626-handler_test.go |
Pins ISO 18626 handler tests. |
broker/test/events/eventbus_test.go |
Pins event-bus tests. |
broker/test/client/client_test.go |
Pins client integration tests. |
broker/test/catalog/holdings_test.go |
Pins catalog holdings tests. |
broker/test/api/api-handler_test.go |
Pins broker API tests. |
broker/cmd/broker/main_test.go |
Pins broker command tests. |
broker/cmd/archive/main_test.go |
Pins archive command tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JanisSaldabols
approved these changes
Aug 31, 2026
jakub-id
reviewed
Aug 31, 2026
adamdickmeiss
requested review from
JanisSaldabols and
jakub-id
and
a balanced review from Copilot
September 1, 2026 09:39
jakub-id
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And wait 30 seconds to avoid testcontainer failures on
"fresh" systems.