Skip to content

Same PG container in all tests - #743

Merged
adamdickmeiss merged 5 commits into
mainfrom
same-pg-container-in-all-tests
Sep 1, 2026
Merged

Same PG container in all tests#743
adamdickmeiss merged 5 commits into
mainfrom
same-pg-container-in-all-tests

Conversation

@adamdickmeiss

@adamdickmeiss adamdickmeiss commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

And wait 30 seconds to avoid testcontainer failures on
"fresh" systems.

Copilot AI balanced review requested due to automatic review settings August 31, 2026 08:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Standardizes PostgreSQL testcontainers on PostgreSQL 16 and increases the Directory integration-test startup timeout.

Changes:

  • Pins all testcontainer images to postgres:16.
  • Raises the Directory database startup timeout to 30 seconds.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
directory/test/00_integration_test.go Pins PostgreSQL 16 and extends startup timeout.
broker/test/utils/utils.go Pins the shared test helper to PostgreSQL 16.
broker/test/service/e2e_test.go Pins the E2E database image.
broker/test/scheduler/service/scheduler_test.go Pins scheduler service tests.
broker/test/scheduler/db/schedrepo_test.go Pins scheduler repository tests.
broker/test/pullslip/api/api_handler_test.go Pins pull-slip API tests.
broker/test/patron_request/db/prrepo_test.go Pins patron-request repository tests.
broker/test/patron_request/api/api-handler_test.go Pins patron-request API tests.
broker/test/handler/iso18626-handler_test.go Pins ISO 18626 handler tests.
broker/test/events/eventbus_test.go Pins event-bus tests.
broker/test/client/client_test.go Pins client integration tests.
broker/test/catalog/holdings_test.go Pins catalog holdings tests.
broker/test/api/api-handler_test.go Pins broker API tests.
broker/cmd/broker/main_test.go Pins broker command tests.
broker/cmd/archive/main_test.go Pins archive command tests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread broker/cmd/archive/main_test.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 25 changed files in this pull request and generated no new comments.

@adamdickmeiss
adamdickmeiss merged commit a984fe0 into main Sep 1, 2026
9 checks passed
@adamdickmeiss
adamdickmeiss deleted the same-pg-container-in-all-tests branch September 1, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants