Add missing address plugin files - #41
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing addressPlugin utility and its unit tests so the UI can consistently select the correct @k-int address plugin (used by ViewEntry and EditEntryRoute) based on configuration.
Changes:
- Introduces
getAddressPlugin()to map configured plugin names to installed address plugin modules, with a generic fallback. - Adds Jest tests verifying correct plugin selection and fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui-rsdir/src/util/addressPlugin.js | Adds getAddressPlugin() for selecting an address plugin by configured name with a generic fallback. |
| ui-rsdir/src/util/addressPlugin.test.js | Adds unit tests covering plugin selection for known keys and fallback cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kurtnordstrom
marked this pull request as ready for review
September 1, 2026 13:26
kurtnordstrom
requested review from
adamdickmeiss,
ihardy,
jakub-id and
skomorokh
as code owners
September 1, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.