Unify index assertions with new util functions - #448
Merged
Merged
Conversation
This makes sure we use consistent messages for index bounds checks, without so much repetition.
youdie006
added a commit
to youdie006/indexmap
that referenced
this pull request
Sep 15, 2026
PR indexmap-rs#448 unified the index assertions in this file, but Core::shift_insert_unique kept a bare assert!(index <= end) and is the only index-taking Core method that panics without #[track_caller]. That leaks through the public VacantEntry::shift_insert, which panics with "assertion failed: index <= end" located in indexmap's internals instead of the caller. Also covers RawVacantEntryMut::shift_insert and shift_insert_hashed_nocheck, which reach the same assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure we use consistent messages for index bounds checks, without so much repetition.