Repository navigation
Release 0.2.6 - #28
Merged
Merged
Conversation
There are cases where we never need the `Equivalent` abstraction. This may not lead to much performance difference, if any, but it should at least be a little lighter burden on the compiler. (cherry picked from commit 4da89f3)
At first glance this may seem worse because it's roughly duplicating the `unsafe` code. However, these are now placed in a dedicated module where the parallels are apparent, and they should be more direct for their respective use-cases. * For disjoint key lookup in a map, we don't need to produce a `Result` that we're just going to turn into panics anyway. * For disjoint indices in a slice, we don't need to deal with `Option`, and we can drop our own unsafe implementation here in favor of the standard library once we update to MSRV 1.86. (cherry picked from commit ddb0316)
(cherry picked from commit 323b679)
This makes sure we use consistent messages for index bounds checks, without so much repetition. (cherry picked from commit 49532eb)
(cherry picked from commit eae6655)
(cherry picked from commit ae47595)
(cherry picked from commit 417437d)
(cherry picked from commit 79f7bd9)
(cherry picked from commit be7ffd0)
(cherry picked from commit 41760c5)
(cherry picked from commit 64f4a06)
(cherry picked from commit 1c2be7b)
(cherry picked from commit 2196365)
(cherry picked from commit c95da18)
(cherry picked from commit af93b43)
(cherry picked from commit ada540e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.