Repository navigation
test: fix Arbitrary for Op - #30
Merged
Merged
Conversation
Commit 72b7032 split the variants for pushing front/back, but missed the modulus length, so we haven't been testing the last `RemoveEntry` variant since then, even though it looked like we had a match case for it. Now we use a slice `choose` to involve them all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 72b7032 split the variants for pushing front/back, but missed the modulus length, so we haven't been testing the last
RemoveEntryvariant since then, even though it looked like we had a match case for it. Now we use a slicechooseto involve them all.This also add
Arbitrary::shrink, and that exhaustive match should help remind us to generate all variants too.