Repository navigation
Implement the 2026-10-07 improvement backlog (2.0.0) - #121
Merged
Merged
Conversation
Second audit round: 44 open items (bugs, robustness, features, UX, CI/docs). No source changes.
…n SafePath and search ROB-02, FEAT-04, FEAT-05, UX-06
…Ridge, path table separator Strip any version suffix and the separator dot of extension-less names, skip associated files, start file data after the extended attribute record, keep Rock Ridge data of multi-extent files, and always use '/' in path table paths.
…t-audit-2026-10-07
… stub fallback, Joliet fallback, raw getBytes, header checks) Partition location/size are both-byte-order, only Joliet SVDs are UTF-16, add getEnhancedVolume(), prefer UDF over a stub ISO 9660 tree, stricter ASCII fallback in Buffer::getString, Buffer::getBytes returns raw bytes, CD001 check, descriptor cap, clear truncated image error, idempotent openFile().
…ata partitions ROB-03: descriptor tags are verified (checksum and location); a failing descriptor is treated as absent. ROB-06: partition lengths are recorded and extents leaving their partition are treated as corrupt. FEAT-01: UDF 2.50 metadata partition maps are read through the allocation extents of the metadata file; sparable and virtual maps are reported by name.
…args; El Torito image size and extraction UX-01 --volume and --no-rock-ridge, UX-02 --files opt-in, UX-03 conflicting actions and bundled flags, UX-05 --list --ndjson, FEAT-03 boot image size, extractImage, multi-sector catalogs, --extract-boot.
…t-audit-2026-10-07
…t-audit-2026-10-07
…t-audit-2026-10-07
…ignore out-of-range GMT offsets SWEEP-01: every exposed date is now Carbon\CarbonImmutable (IsoDate, Volume, FileDirectory, IsoEntry, RockRidgeInfo, UdfNode), so descriptors cannot be mutated through their properties. BUG-10: IsoDate::createWithOffsetMinutes validates with checkdate(). ROB-07: GMT offsets outside -48..+52 (15 min units) or -720..+780 minutes are treated as UTC instead of dropping the date.
…t-audit-2026-10-07
…penStream - UDF: decode symlink targets, skip devices/FIFOs/sockets (BUG-11) - IsoEntry: symlinkTarget, uid, gid, mode from UDF and Rock Ridge PX (FEAT-07) - FileSystem::listDirectory() and getEntryRanges(); find() descends per component (FEAT-02) - openStream() reads lazily through the EntryStream wrapper (FEAT-06)
…t-audit-2026-10-07
…sotool --strict) walk(), listDirectory(), find(), search() and Extractor::extract() accept an optional WalkWarnings collector recording depth limits, unreadable/too large/truncated directories, corrupt directory records and UDF root/entry errors. Volume::walk/listDirectory take the collector as third parameter (before bool \$rockRidge\) to stay compatible with FileSystem. isotool prints them as WARNING: lines on stderr; --strict fails on the first one.
…te dates raised a PHP warning
…ile system edge cases; drop dead branches
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 752 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
============================================
+ Coverage 96.87% 97.42% +0.55%
- Complexity 592 888 +296
============================================
Files 22 25 +3
Lines 1344 1904 +560
============================================
+ Hits 1302 1855 +553
- Misses 42 49 +7 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements every item of the second improvement audit,
docs/improvement-audit/2026-10-07-improvement-backlog.md: 44 items, all ticked. The backlog document is included in this PR.This targets 2.0.0. It contains BC breaks, which are listed in
CHANGELOG.mdand explained with before/after snippets inUPGRADE-2.0.md.Highlights
Parsing fixes
getEnhancedVolume().getFileSystem()now returns the UDF file system.;Nversion and the trailing separator dot (README.;1becomesREADME).getFullPath()always uses/.Robustness
CD001identifier and are capped at 64.CEhandling fixed andSPlen_skphonoured.SafePathrejects Windows reserved names and characters.Features
TF/PN.IsoEntrygainsuid,gid,modeandsymlinkTarget.find()reads only the directories on the path (listDirectory()).openStream()is a lazy, seekable stream (Util\EntryStream).Extractorkeeps file times, withpreserveModeandcontinueOnError/getErrors().WalkWarningsmakes incomplete listings detectable, with a strict mode that throws.CarbonImmutable.CLI
--volume=primary|joliet|udf,--no-rock-ridge,--files,--ndjson,--extract-boot,--strict.-lj).--fileexits with code 1.Tests, CI and docs
fixtures/build-fixtures.sh): Rock Ridge, ISO 9660:1999, Joliet CJK, and names without extension.tests:coverageworks with Xdebug; dev files are export-ignored.SECURITY.mdnow points to private vulnerability reporting.CHANGELOG.mdandUPGRADE-2.0.md.Main BC breaks
CarbonImmutable.FileSystemgainedlistDirectory()andgetEntryRanges(), and an optionalWalkWarningsparameter onwalk,listDirectory,findandsearch.Volume::walk($isoFile, $depth, $warnings, $rockRidge): Rock Ridge is now the last parameter.getSupplementaryVolume()returns only Joliet descriptors.--files.Known limits
preserveModechmod test is skipped on Windows.Verification
composer run checkpasses: phpcs, phpstan, rector and phpunit (608 tests, 2196 assertions, 1 skipped on Windows).composer audit, gitleaks and actionlint are clean. Line coverage is 97.1%.🤖 Generated with Claude Code