Preserve exit values above 127 when reaping children - #55
Merged
Conversation
When a child process exits with a code above 127, Process.waitFor() and Process.exitValue() return a negative number. This happens because VMProcess.nativeReap() incorrectly casts WEXITSTATUS() to jbyte (which is signed) before publishing it, so e.g. exit code 128 is reported as -128 and 250 as -6. In addition, the incorrect values can be mistaken for signal deaths, which Classpath reports as the negative signal number (so -6 is what is reported when a child is killed by SIGABRT). Fix by removing the incorrect jbyte cast. Fixes #54 (BZ#126651) Signed-off-by: Guillermo Rodríguez <grodriguez@ingelabs.com>
phvega
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a child process exits with a code above 127, Process.waitFor() and Process.exitValue() return a negative number. This happens because VMProcess.nativeReap() incorrectly casts WEXITSTATUS() to jbyte (which is signed) before publishing it, so e.g. exit code 128 is reported as -128 and 250 as -6.
In addition, the incorrect values can be mistaken for signal deaths, which Classpath reports as the negative signal number (so -6 is what is reported when a child is killed by SIGABRT).
Fix by removing the incorrect jbyte cast.
Fixes #54 (BZ#126651)