Skip to content

Add d_pkparam() and h_pkparam_sort() for PP LTGs. - #288

Open
qiliu1013 wants to merge 7 commits into
mainfrom
286_h_pkparam_sort
Open

Add d_pkparam() and h_pkparam_sort() for PP LTGs.#288
qiliu1013 wants to merge 7 commits into
mainfrom
286_h_pkparam_sort

Conversation

@qiliu1013

Copy link
Copy Markdown
Collaborator

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Close #286


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@qiliu1013
qiliu1013 requested a review from shajoezhu July 23, 2026 18:43
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files  260 suites   2m 56s ⏱️
260 tests 260 ✅ 0 💤 0 ❌
760 runs  760 ✅ 0 💤 0 ❌

Results for commit 0d973a8.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
add_forest 💔 $0.55$ $+1.93$ add_forest_table_engine_flextable_works
add_hierarchical_count_row 💚 $3.10$ $-2.43$ add_hierarchical_count_row_works
annotate_gg_pkc 💚 $2.76$ $-1.17$ annotate_pkc_df_warns_when_given_a_standard_ggplot_object
tbl_hierarchical_incidence_rate 💔 $15.04$ $+1.50$ tbl_hierarchical_incidence_rate_runs_with_minimum_arguments
tbl_hierarchical_rate_by_grade 💚 $18.37$ $-3.33$ tbl_hierarchical_rate_by_grade_works
tbl_roche_subgroups 💚 $3.31$ $-2.77$ tbl_roche_subgroups_time_to_event_NULL_works
tbl_roche_summary 💔 $2.56$ $+3.06$ tbl_roche_summary_works
tbl_shift 💔 $4.86$ $+2.07$ tbl_shift_strata_location_
tbl_with_pools 💚 $9.73$ $-2.39$ tbl_with_pools_validates_inputs_correctly

Results for commit 7e28aef

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/add_blank_rows.R                          63       0  100.00%
R/add_difference_row.R                     101       0  100.00%
R/add_forest_utils.R                        97      10  89.69%   76-79, 94-100
R/add_forest.R                             139       0  100.00%
R/add_hierarchical_count_row.R              33       0  100.00%
R/adjust_stat_columns_wrap.R                29       1  96.55%   59
R/annotate_gg_km.R                         141       0  100.00%
R/annotate_gg_pkc.R                         92       0  100.00%
R/annotate_gg.R                             81       0  100.00%
R/ard_tabulate_abnormal_by_baseline.R       65       0  100.00%
R/crane-package.R                            2       2  0.00%    26-27
R/deprecated.R                              21      21  0.00%    18-54
R/df_add_poolings.R                         41       0  100.00%
R/get_cox_pairwise_df.R                    163       0  100.00%
R/gg_km_utils.R                             39      14  64.10%   20-37
R/gg_km.R                                  143      37  74.13%   55-58, 75, 102, 176-181, 184-187, 197-199, 204-205, 239-241, 248-251, 255, 266-270, 283, 285-287
R/gg_lineplot.R                             94       0  100.00%
R/gg_mmrm_lineplot.R                       102       1  99.02%   106
R/gg_pkc_lineplot.R                         98       0  100.00%
R/gg_utils.R                               222       0  100.00%
R/h_pkparam_sort.R                         427     427  0.00%    12-468
R/label_roche.R                             72       0  100.00%
R/modify_header_rm_md.R                     18       2  88.89%   35-36
R/modify_zero_recode.R                      20       1  95.00%   64
R/reverse_difference_ci.R                   33       0  100.00%
R/tbl_baseline_chg.R                       188       0  100.00%
R/tbl_coxph.R                               90       1  98.89%   229
R/tbl_hierarchical_incidence_rate.R        291       4  98.63%   430-433
R/tbl_hierarchical_rate_and_count.R        339      13  96.17%   343, 425, 446-456
R/tbl_hierarchical_rate_by_grade.R         317       3  99.05%   169-171
R/tbl_listing.R                             35       0  100.00%
R/tbl_mmrm.R                               254       1  99.61%   393
R/tbl_null_report.R                          9       0  100.00%
R/tbl_rmpt.R                               157      12  92.36%   299-304, 316-321
R/tbl_roche_subgroups.R                    155       0  100.00%
R/tbl_roche_summary.R                       64       0  100.00%
R/tbl_shift.R                              116       0  100.00%
R/tbl_survfit_quantiles.R                  154       0  100.00%
R/tbl_survfit_times.R                       92       0  100.00%
R/tbl_with_pools.R                          64       0  100.00%
R/theme_gtsummary_roche.R                   87       1  98.85%   61
R/utils.R                                   42       0  100.00%
TOTAL                                     4790     551  88.50%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/h_pkparam_sort.R     +427    +427  +100.00%
TOTAL                  +427    +427  -8.66%

Results for commit: 0d973a8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu

Copy link
Copy Markdown
Contributor

hi @qiliu1013 , there is quite a lot broken tests, can you fix them. Thanks

@qiliu1013
qiliu1013 force-pushed the 286_h_pkparam_sort branch from db39330 to db3b7ed Compare August 4, 2026 20:27
@qiliu1013

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@qiliu1013

Copy link
Copy Markdown
Collaborator Author

hi @qiliu1013 , there is quite a lot broken tests, can you fix them. Thanks

@shajoezhu All checks passed.

Comment thread R/h_pkparam_sort.R
@@ -0,0 +1,469 @@
#' Generate PK reference dataset
#'
#' @description `r lifecycle::badge("stable")`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this line for now. this is experiemental at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add h_pkparam_sort()

2 participants