Add d_pkparam() and h_pkparam_sort() for PP LTGs. - #288
Conversation
|
✅ All contributors have signed the CLA |
Unit Tests Summary 1 files 260 suites 2m 56s ⏱️ Results for commit 0d973a8. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 7e28aef ♻️ This comment has been updated with latest results. |
Code Coverage SummaryDiff against mainResults for commit: 0d973a8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
hi @qiliu1013 , there is quite a lot broken tests, can you fix them. Thanks |
db39330 to
db3b7ed
Compare
|
I have read the CLA Document and I hereby sign the CLA |
@shajoezhu All checks passed. |
| @@ -0,0 +1,469 @@ | |||
| #' Generate PK reference dataset | |||
| #' | |||
| #' @description `r lifecycle::badge("stable")` | |||
There was a problem hiding this comment.
can we remove this line for now. this is experiemental at the moment
What changes are proposed in this pull request?
NEWS.md. (#, @)Provide more detail here as needed.
Close #286
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).