[1905 by GPT-5.6 Sol] Make /use change only the PR model label - #1909
[1905 by GPT-5.6 Sol] Make /use change only the PR model label#1909propr-dev[bot] wants to merge 8 commits into
Conversation
Implemented by ProPR AI using gpt-5.6-sol model. Implementation completed successfully.
|
Please make one narrow correction on this exact head. Replace the new manual target-resolution logic with ProPR’s existing canonical enabled agent/model resolver so |
|
✅ Applied the requested follow-up changes in commit 28dab91 Summary of ChangesImplemented the narrow
Validation:
🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented the narrow `/use` correction on the exact PR head. - Replaced manual target matching with `resolveReviewModels`, ProPR’s canonical enabled agent/model resolver. - Builds canonical static or dynamic labels from the resolved pair. - Preserves scoped `MODEL_LABEL_PATTERN` replacement behavior. - Added regressions for configured aliases, case-insensitive model IDs, dynamic labels, and hashed full labels. - Left `/switch`, queues, persistence, pending comments, retries, and task state untouched. Validation: - Focused suite: 61/61 passed. - Hashed-label suite: 3/3 passed. - Typecheck passed. - No commit created. PR: #1909 Comment by: @integry (ID: 5298204684) Model: gpt-5.6-sol
|
/merge |
|
🔀 Auto-merged No conflicts were found — the merge was verified by an AI agent. 🤖 Verification Details
System-triggered merge conflict resolution |
…-use-change-only-the--20260814-2046-swx
|
Please make one final narrow label-mutation correction on this exact post-merge head. |
|
✅ Applied the requested follow-up changes in commit 5899597 Summary of ChangesImplemented the narrow
Changed: Validation:
🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented the narrow `/use` correction on the exact PR head. - `/use` now always fetches live PR labels, including review-comment events. - Missing targets are added before stale managed labels are removed. - Failed target additions abort cleanup, preserving existing managed labels. - Target-present behavior removes only stale labels. - Failure logging, idempotency, and no-queue/pending-state behavior remain intact. - Added focused regressions for stale review payloads and failed-add preservation. Changed: - [commentEventHandler.ts](/tmp/git-processor/worktrees/integry/propr/pr-1909-followup-2026-08-14T21-25-35/packages/core/src/webhook/commentEventHandler.ts) - [commentEventHandler.switch-use.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-1909-followup-2026-08-14T21-25-35/test/commentEventHandler.switch-use.test.ts) Validation: - Focused suite: 63/63 passed - Typecheck passed - `git diff --check` passed - No commit created PR: #1909 Comment by: @integry (ID: 5298323060) Model: gpt-5.6-sol
|
/review codex-gpt55 |
|
✅ AI Code Review Complete requested by @integry Posted 1 review: |
🔍 AI Code Review — codex-gpt55Overall EvaluationThis PR is ready to merge. It narrows ✅ Live PR labels — ✅ Safe add-first order — the target label is added before stale managed labels are removed, and add failure aborts removals. ✅ Focused regressions — tests cover stale review-comment payload labels, add failure preservation, aliases, full labels, dynamic labels, idempotency, and no queueing. Merge blockersNo merge blockers. SuggestionsThese are optional follow-ups and are not sent to S1: 🟢 Custom Prefix CoverageThe new implementation derives a label prefix from ScoreThe PR satisfies the requested narrow behavior, has current-head checks passing, and includes targeted tests for the recent correction points. The remaining suggestion is optional coverage hardening, not a merge blocker. Score: 9/10 🤖 Review Details
🤖 Review by ProPR |
|
/ultrafix goal=8 max=10 |
|
🔄 Ultrafix loop started (goal: 8/10, max cycles: 10) First action:
|
|
✅ AI Code Review Complete requested by @integry Posted 1 review: |
🔍 AI Code Review — codex:gpt-5.6-solOverall EvaluationThis PR correctly redefines ✅ Label-only control flow — ✅ Careful label selection — The handler reads live PR labels, preserves unrelated labels, and treats an already-active canonical label as an idempotent no-op. ✅ Validated model resolution — Targets must resolve to a supported model on an enabled configured agent before mutation begins. Merge blockersEvery finding below was introduced by this PR and must be resolved before merging. F1: 🔴 Failed removal leaves ambiguous routing
F2: 🔴 Custom prefixes can exceed GitHub limits
SuggestionsThese are optional follow-ups and are not sent to No suggestions. ScoreThe core behavior and test coverage are strong, but the failure-path routing ambiguity and invalid-label construction for supported custom-prefix configurations must be corrected before merge. Score: 6/10 🤖 Review Details
🤖 Review by ProPR |
|
✅ Applied the requested follow-up changes in commit a5bfb27
Summary of ChangesImplemented only F1 and F2, without committing.
Verification passed:
🤖 Implementation Details
💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented only F1 and F2, without committing. - F1: stale-label removal failure now compensates by removing the newly added target label. - F2: canonical labels now use the configured prefix’s actual 50-character budget while retaining stable hashes and routing round trips. - Added focused regressions in [commentEventHandler.switch-use.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-1909-followup-2026-08-14T21-51-07/test/commentEventHandler.switch-use.test.ts:732). Verification passed: - 65 targeted tests - Repository-wide TypeScript check - Core package TypeScript check - Package-local ESLint - `git diff --check` PR: #1909 Comment by: @propr-ultrafix (ID: 0) Model: gpt-5.6-sol
|
✅ AI Code Review Complete requested by @propr-ultrafix Posted 1 review: |
🔍 AI Code Review — codex:gpt-5.6-solOverall EvaluationThe PR correctly narrows ✅ Work remains isolated — ✅ Live labels and failures are handled carefully — the implementation reads current PR labels, preserves unrelated labels, validates enabled model support, and avoids success logging when mutations fail. Merge blockersEvery finding below was introduced by this PR and must be resolved before merging. F3: 🔴 Validate generated label routing
F4: 🔴 Accept configured-prefix full labels
F5: 🔴 Compare labels case-insensitively
SuggestionsThese are optional follow-ups and are not sent to S1: 🟢 Restore partial removalsIf removal of several stale labels partially succeeds, the failure path removes the newly added target but does not restore labels listed in S2: 🟢 Centralize prefixed label building
ScoreThe principal behavior and tests are solid, and all current checks pass, but the three routing and label-identity edge cases can produce incorrect successful outcomes. The fixes are localized. Score: 6/10 🤖 Review Details
🤖 Review by ProPR |
|
✅ Applied the requested follow-up changes in commit 133f79a
Summary of ChangesImplemented F3, F4, and F5 only.
Verification passed:
No commit created. 🤖 Implementation Details
💡 ProPR Slash Commands
🤖 Generated by ProPR |
|
Every PR can have just a single LLM label at the same time, there can be no ambiguity. Just change the fucking label. |
Implemented F3, F4, and F5 only. - Validates generated routing tokens resolve to the exact selected agent/model. - Supports full labels using custom `MODEL_LABEL_PATTERN` prefixes. - Compares GitHub labels case-insensitively to preserve idempotency. - Added regressions for truncated alias collisions, custom-prefix labels, and mixed-case labels. Verification passed: - Focused suite: 68 tests - TypeScript typecheck - Core ESLint - `git diff --check` No commit created. PR: #1909 Comment by: @propr-ultrafix (ID: 0) Model: gpt-5.6-sol
|
✅ Applied the requested follow-up changes in commit 30651b3 Summary of ChangesImplemented the follow-up correction.
Validation passed:
No commit created. 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented the follow-up correction. - `/use` now replaces the live PR label set in one request, preserving unrelated labels and leaving exactly one managed LLM label. - Failed replacement leaves existing labels untouched and does not claim success or enqueue work. - Updated focused regressions in [commentEventHandler.switch-use.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-1909-followup-2026-08-14T22-22-00/test/commentEventHandler.switch-use.test.ts). Validation passed: - 68/68 focused tests - TypeScript typecheck - Core ESLint - `git diff --check` No commit created. PR: #1909 Comment by: @integry (ID: 5298715670) Model: gpt-5.6-sol
|
/review |
|
✅ AI Code Review Complete requested by @integry Posted 1 review: |
🔍 AI Code Review — codex:gpt-5.6-solOverall EvaluationThis PR correctly reframes ✅ Label-only control flow — ✅ Canonical live resolution — The handler uses Merge blockersEvery finding below was introduced by this PR and must be resolved before merging. F6: 🔴 Replace-all update can lose unrelated labels
SuggestionsThese are optional follow-ups and are not sent to S1: 🟢 Centralize prefixed label construction
ScoreThe core control flow, resolution behavior, and regression coverage are strong, but the label replacement strategy can violate a central preservation requirement. The remaining correction is localized; the pending full-suite check should complete afterward. Score: 6/10 🤖 Review Details
🤖 Review by ProPR |
|
Any model specific labels are prefixed via "llm-" so the operation is simple - remove all llm- prefixed labels and add the new label. |
|
✅ Applied the requested follow-up changes in commit d869904 Summary of ChangesImplemented the narrow
Files changed: Validation passed: 69 focused tests, TypeScript typecheck, core ESLint, and 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented the narrow `/use` correction: - Removes every live PR label prefixed with `llm-`. - Adds the resolved canonical target once. - Preserves unrelated labels and idempotent behavior. - Added focused regression coverage. Files changed: - [commentEventHandler.ts](/tmp/git-processor/worktrees/integry/propr/pr-1909-followup-2026-08-14T22-45-04/packages/core/src/webhook/commentEventHandler.ts:459) - [commentEventHandler.switch-use.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-1909-followup-2026-08-14T22-45-04/test/commentEventHandler.switch-use.test.ts:629) Validation passed: 69 focused tests, TypeScript typecheck, core ESLint, and `git diff --check`. No commit created. PR: #1909 Comment by: @integry (ID: 5298894213) Model: gpt-5.6-sol
|
/review |
|
✅ AI Code Review Complete requested by @integry Posted 1 review: |
🔍 AI Code Review — codex:gpt-5.6-solOverall EvaluationThis PR correctly narrows ✅ No work is queued — ✅ Live labels are consulted — the handler calls the live PR lookup instead of relying on potentially stale review-comment payload labels. ✅ Canonical resolution is well covered — tests exercise short aliases, configured agent aliases, case-insensitive IDs, and dynamic/hashed labels. Merge blockersEvery finding below was introduced by this PR and must be resolved before merging. F7: 🔴 Managed labels ignore configured pattern
F8: 🔴 Whole-label replacement permits lost updates
SuggestionsThese are optional follow-ups and are not sent to S1: 🟢 Centralize prefixed label constructionThe new ScoreThe resolution and no-enqueue behavior are well tested and all current checks pass, but the two label-mutation defects can retain stale managed labels or lose concurrent unrelated-label changes. Score: 6/10 🤖 Review Details
🤖 Review by ProPR |
AI Implementation Summary
Closes #1905
Branch:
1905/gpt-5.6-sol-make-use-change-only-the--20260814-2046-swxCommits: ✅ Changes committed (540bacc)
AI Processing Completed
Execution Details:
Summary:
Implemented issue #1905.
Key changes:
/use <model-or-label>now updates only the PR’s canonical managed model label./switchbehavior unchanged.Validation:
Detailed Logs:
01a00207-f92e-7671-80f8-59b09ffe9c40Log files stored at:
/tmp/claude-logs/issue-1905-2026-08-14T21-07-56-136Z-conversation.json/tmp/claude-logs/issue-1905-2026-08-14T21-07-56-136Z-output.txtLatest Conversation Messages
This PR was created automatically by ProPR after processing issue #1905.
💡 Need changes?
Comment on this PR to request refinements — the AI agent monitors comments and will update the implementation based on your feedback. Keep iterating until you're satisfied!