fix: stabilize migrations, Codex streams, and demo usage - #1949
Open
integry wants to merge 6 commits into
Open
Conversation
Owner
Author
|
/review codex |
Contributor
|
✅ AI Code Review Complete requested by @integry Posted 1 review: |
Contributor
🔍 AI Code Review — codexOverall EvaluationThis PR is ready to merge. It correctly defaults automated Codex runs to an OpenAI-compatible SSE provider, exposes validated timeout and retry controls, and preserves custom-provider behavior through ✅ Correct precedence — Stream settings resolve from process defaults through agent configuration to per-execution overrides. ✅ Safe escape hatch — ✅ Aligned verification and documentation — Default, override, fallback, and inheritance behavior are tested and documented, and all current head checks pass. Merge blockersNo merge blockers. SuggestionsThese are optional follow-ups and are not sent to No suggestions. ScoreThe implementation is focused, internally consistent, well-tested, and merge-ready within scope, with no identified regressions or failing checks. Score: 9/10 🤖 Review Details
🤖 Review by ProPR |
integry
changed the title
Full Test Suite ResultsValidation failed during: Full test suite.
View Test Output |
integry
changed the title
Checks FailedValidation failed during setup, tests, CLI packaging, linting, or build checks. View Logs |
Contributor
|
✅ Applied the requested follow-up changes in commit b3d6f8f Summary of ChangesFixed the CI lint failure in packages/core/src/index.ts by compacting the migration-gate exports without changing the public API. Validated:
No commit was created. 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
![propr-dev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…tmp/git-processor/worktrees/integry/propr/pr-1949-followup-2026-08-29T13-41-54/packages/core/src/index.ts:78) by compacting the migration-gate exports without changing the public API. Fixed the CI lint failure in [packages/core/src/index.ts](/tmp/git-processor/worktrees/integry/propr/pr-1949-followup-2026-08-29T13-41-54/packages/core/src/index.ts:78) by compacting the migration-gate exports without changing the public API. Validated: - Exact CI ESLint command passes with zero warnings - `@propr/core` full lint passes - `@propr/core` build passes - `git diff --check` passes No commit was created. PR: #1949 Comment by: @github-actions[bot] (ID: 5462742930) Model: gpt-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inheritescape hatch for user-managed Codex providersWhy
The notification preference migration used a database-wide
PRAGMA foreign_key_checkafter rebuildingpush_subscriptions. Legacy violations in unrelated tables therefore blocked startup even when the rebuild introduced no new integrity problems. The migration now snapshots the existing violation multiset and rolls back only if new violations appear.Every backend process runs the migration gate during startup. When one process was applying a valid migration, siblings treated Knex's temporary
MigrationLockedresult as fatal and exited. The gate now retries only that lock condition for up to 60 seconds; real migration failures still fail immediately, and foreign-key enforcement is restored on every exit path.Recent Codex releases use the Responses WebSocket transport by default. Long quiet model responses can hit its stream idle timeout before completion, leading to reconnect exhaustion even though the overall ProPR task timeout has not elapsed. The implementation uses current provider configuration keys instead of the removed
responses_websocketsfeature flag.The demo UI also hid its usage sidebar because the underlying route required the agent-management permission. Demo-scoped authorization now permits only that read-only usage endpoint, while the remaining Agent Tank management endpoints stay restricted.
Verification
npm run typechecknpm run build/healthreturns{"status":"ok"}git diff --check