[1958 by GPT-5.6 Sol] Extract the UI-agnostic local setup engine for CLI and desktop use - #1963
Merged
integry merged 4 commits intoAug 29, 2026
Conversation
![propr-dev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…gine for CLI Implemented by ProPR AI using gpt-5.6-sol model. Implementation completed successfully.
Checks FailedValidation failed during setup, tests, CLI packaging, linting, or build checks. View Logs |
Contributor
Author
|
✅ Applied the requested follow-up changes in commit b08e5f1 Summary of ChangesImplemented the follow-up fix without committing.
Verified successfully:
Docker was unavailable locally, so the exact containerized 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented the follow-up fix without committing. - [pr-build-check.yml](/tmp/git-processor/worktrees/integry/propr/pr-1963-followup-2026-08-29T14-25-06/.github/workflows/pr-build-check.yml:34) now builds `@propr/local-setup` before every affected CLI typecheck/test. - [build-publish.mjs](/tmp/git-processor/worktrees/integry/propr/pr-1963-followup-2026-08-29T14-25-06/packages/cli/scripts/build-publish.mjs:77) now builds and vendors `@propr/local-setup`, rewriting private workspace imports for the standalone CLI package. Verified successfully: - Local-setup and CLI typechecks - CLI lint - Hosted-tunnel suite: 312 tests passed - Init JSON suite: 12 passed - Local-setup suite: 9 passed - Agent Skill suite: 62 passed, 1 platform skip - CLI package dry-run and installed-tarball smoke test - YAML parsing and `git diff --check` Docker was unavailable locally, so the exact containerized `actionlint` invocation could not run. PR: #1963 Comment by: @github-actions[bot] (ID: 5462947943) Model: gpt-5.6-sol
Full Test Suite ResultsValidation failed during: Full test suite.
View Test Output |
Contributor
Author
|
✅ Applied the requested follow-up changes in commit 56c97eb Summary of ChangesFixed the full-suite failure in taskInspectCommands.test.ts. The test now validates concurrent state requests without assuming nondeterministic request order. Canonical output ordering remains separately verified. Validation:
🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…s](/tmp/git-processor/worktrees/integry/propr/pr-1963-followup-2026-08-29T14-34-00/packages/cli/src/commands/taskInspectCommands.test.ts:107). Fixed the full-suite failure in [taskInspectCommands.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-1963-followup-2026-08-29T14-34-00/packages/cli/src/commands/taskInspectCommands.test.ts:107). The test now validates concurrent state requests without assuming nondeterministic request order. Canonical output ordering remains separately verified. Validation: - Focused test passed 20 consecutive runs - CLI typecheck passed - `git diff --check` passed - No commit created PR: #1963 Comment by: @github-actions[bot] (ID: 5462991038) Model: gpt-5.6-sol
Owner
|
!propr Independent diagnosis of the remaining Node 22 and Node 24 "Project options" failures:
Please update the workflow that owns both Project options matrix jobs (not only |
Contributor
Author
|
✅ Applied the requested follow-up changes in commit b20ae26 Summary of ChangesImplemented the follow-up in cli-node-compatibility.yml:
Validation passed:
Only the compatibility workflow is modified. No commit was created. 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…tmp/git-processor/worktrees/integry/propr/pr-1963-followup-2026-08-29T14-56-46/.github/workflows/cli-node-compatibility.yml:6): Implemented the follow-up in [cli-node-compatibility.yml](/tmp/git-processor/worktrees/integry/propr/pr-1963-followup-2026-08-29T14-56-46/.github/workflows/cli-node-compatibility.yml:6): - Builds `@propr/shared`, then `@propr/local-setup`, before project-options tests. - Triggers compatibility checks when `packages/local-setup/**` changes. - Audited other clean-checkout CLI paths; they already prepare both dependencies via explicit builds, `test:prepare`, or self-contained `cli:pack`. Validation passed: - Node 22: 26/26 project-options tests - Node 24: 26/26 project-options tests - Full suite: all 309 test files plus UI workspace passed; UI 465/465 tests - `npm run cli:pack` - Actionlint 1.7.12 - Workflow YAML parsing and `git diff --check` Only the compatibility workflow is modified. No commit was created. PR: #1963 Comment by: @integry (ID: 5463097453) Model: gpt-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Implementation Summary
Closes #1958
Branch:
1958/gpt-5.6-sol-extract-the-ui-agnostic-l-20260829-1408-o4cCommits: ✅ Changes committed (5e5e890)
AI Processing Completed
Execution Details:
Summary:
Implemented issue #1958.
Key changes:
@propr/local-setup, containing the UI-agnostic setup state machine, typed steps/state, prompts, progress events, host-operation interfaces, structured errors, cancellation, retry, and resumable re-runs..envpermissions and non-destructive secret handling.Verification completed:
npm run test:preparenpm run typecheck -w @propr/local-setupnpm run typecheck -w @propr/clinpm test -w @propr/local-setup— 9 passednpm run lint -w @propr/clinpm pack -w @propr/local-setup --dry-runmacOS and Windows behavior was validated through injected platform tests; those operating systems were not exercised directly.
Detailed Logs:
01a04ddb-441f-75e2-8e35-c9624ecf9ee3Log files stored at:
/tmp/claude-logs/issue-1958-2026-08-29T14-23-45-905Z-conversation.json/tmp/claude-logs/issue-1958-2026-08-29T14-23-45-905Z-output.txtLatest Conversation Messages
This PR was created automatically by ProPR after processing issue #1958.
💡 Need changes?
Comment on this PR to request refinements — the AI agent monitors comments and will update the implementation based on your feedback. Keep iterating until you're satisfied!