Repository navigation
[IN-200]: ci: run tests inside production image - #233
Merged
Merged
Conversation
bullseye packages return 404. node:16 already ships build tools.
Move test stack and env to compose. Exclude .env files from image.
apsantiso
marked this pull request as ready for review
November 6, 2026 14:25
apsantiso
changed the title
sg-gs
reviewed
Nov 6, 2026
sg-gs
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Production deployments are not working. The last successful
build & deployon master was on 2026-08-19.The last four merges failed and did not reach production:
d7c9fa5121892ba45cd06764c37bd41eCI did not catch it because tests run on the runner and never build the
Dockerfile.Changes
Dockerfile,infrastructure/preview.Dockerfile,infrastructure/development.Dockerfile: usenode:16and drop the apt step. The image already includes the build tools.ci.yml: build the production image on PRs and run unit and e2e tests inside it. No longer runs on pushes to master.docker-compose.test.yml,.env.test: test stack and fake env values, moved out ofci.yml.Notes