Skip to content

[]fix/change wrong text and put card payment option collapsed by default - #2246

Merged
internxt-yu merged 3 commits into
masterfrom
fix/wrong-text-in-urgent-checkout
Nov 6, 2026
Merged

internxt-yu merged 3 commits into
masterfrom
fix/wrong-text-in-urgent-checkout

Conversation

@internxt-yu

@internxt-yu internxt-yu commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

changed in urgent checkout to have differents texts when is subscription plan or lifetime plan, before the text was purchase with the price x for the first month in both cases. Also make the Card payment option to be collapsed in the begining so the user can reach to the payment button without too many scroll.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Text to change:
changed text

For the lifetime plan, enter and see if the text "for the first month" is removed:
https://fix-wrong-text-in-urgent-che.drive-web.pages.dev/checkout-uc?planId=price_1UNa3UFAOdcgaBMQOxm4ZPlk&couponCode=80OFFLFT&planType=individual&currency=eur&mode=payment

For the subscription plan is keeping the text "for first month"
https://fix-wrong-text-in-urgent-che.drive-web.pages.dev/checkout-uc?planId=price_1UNa3UFAOdcgaBMQVWHe5MtC&couponCode=CYBERLAB&planType=individual&currency=eur&mode=subscription

And by default the card payment method is collapsed like other two payment methods.

Additional Notes

Summary by CodeRabbit

  • New Features

    • Checkout messaging now reflects the selected monthly, yearly, or lifetime plan, with pricing details tailored to each billing period.
    • Added a benefit highlighting the included privacy tools.
  • Updates

    • Revised subscription and lifetime plan button labels.
    • Payment options now start collapsed by default.

@internxt-yu internxt-yu self-assigned this Oct 23, 2026
@internxt-yu internxt-yu added the bug Something isn't working label Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 439d5b84-b15b-4886-bc72-2f985ff53c5d
Commits

Reviewing files that changed from the base of the PR and between 2a6146b and b5a6501.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

Urgent checkout now shows subtitles based on the selected plan interval, adds a suite selling point, and uses updated CTA labels in nine locales. The Stripe Payment Element accordion starts collapsed. Tests cover yearly and lifetime headline wording and updated checkout copy.

Changes: Urgent checkout

Layer / File(s) Summary
Plan-specific hero content
src/app/i18n/locales/*.json, src/views/UrgentCheckout/components/UrgentCheckoutHero.tsx, src/views/UrgentCheckout/views/UrgentCheckoutView.test.tsx
The hero selects a subtitle for the plan interval and displays a suite selling point. Translations update CTA labels. Tests cover yearly and lifetime headlines, suite copy, and CTA text.
Payment accordion default
src/views/UrgentCheckout/components/UrgentCheckoutPaymentSection.tsx
The Stripe Payment Element accordion defaults to collapsed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: candelr, xabg2

Merge Risk: Minimal · previous review 2a614

The urgent-checkout messaging and collapsed payment layout are mergeable with normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title names both main changes: different urgent-checkout text for subscription and lifetime plans, and the card payment option collapsed by default. It matches the raw summary and the PR objective…
Description check Passed The description covers the main change. It explains the plan-specific text (subscription vs. lifetime) and the collapsed card payment option, and it gives reasons for both. The testing process section…
Docstring Coverage Passed Docstring coverage is inconclusive: files from earlier reviews still need to be rechecked within the check's analysis limits. Not blocking.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names both main changes: different urgent-checkout text for subscription and lifetime plans, and the card payment option collapsed by default. It matches the raw summary and the PR objectives. The title is 72 characters and 11 words, which is long, but it is specific and not vague. The leading "[]" is a stray prefix that adds noise.

Full details: Description check

Explanation

The description covers the main change. It explains the plan-specific text (subscription vs. lifetime) and the collapsed card payment option, and it gives reasons for both. The testing process section gives two test URLs and a screenshot. The template sections for Related Issues and Related Pull Requests are left as placeholder comments. The Additional Notes section is also unfilled. Several checklist items are unchecked: coding standards, documentation, and QA. The description template's HTML comment placeholders remain in the Description and Testing Process sections.

Resolution

Optional improvements: remove the leftover template comments; state "None" under Related Issues and Related Pull Requests, or add links; add notes under Additional Notes if any; and confirm the unchecked checklist items (coding standards, documentation, QA) before merge.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9e758bfd-1c93-4185-a18c-997127e6ac06
Commits

Reviewing files that changed from the base of the PR and between cd78510 and 2a6146b.

Files selected for processing: 9

  • src/app/i18n/locales/de.json
  • src/app/i18n/locales/en.json
  • src/app/i18n/locales/es.json
  • src/app/i18n/locales/fr.json
  • src/app/i18n/locales/it.json
  • src/app/i18n/locales/pt.json
  • src/app/i18n/locales/ru.json
  • src/app/i18n/locales/tw.json
  • src/app/i18n/locales/zh.json
Files skipped from review as they are similar to previous changes: 1

  • src/app/i18n/locales/en.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@internxt-yu
internxt-yu marked this pull request as ready for review October 26, 2026 07:36
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5a6501
Status: ✅  Deploy successful!
Preview URL: https://10e488a6.drive-web.pages.dev
Branch Preview URL: https://fix-wrong-text-in-urgent-che.drive-web.pages.dev

View logs

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@internxt-yu
internxt-yu merged commit 05b9095 into master Nov 6, 2026
11 of 12 checks passed
@internxt-yu
internxt-yu deleted the fix/wrong-text-in-urgent-checkout branch November 6, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants