Skip to content

[PB-4449]: refactor/remove the legacy upload code - #2272

Closed
xabg2 wants to merge 1 commit into
refactor/upload-shared-viewfrom
refactor/upload-legacy-cleanup
Closed

xabg2 wants to merge 1 commit into
refactor/upload-shared-viewfrom
refactor/upload-legacy-cleanup

Conversation

@xabg2

@xabg2 xabg2 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Description

  • Removes the old upload flow, no longer used now that every upload goes through the new one: the old upload actions, the folder upload managers, the old file and folder upload tasks and their retry paths.
  • The retry list of failed downloads keeps working as before; failed uploads are retried from their own task.
  • Removes the translations that only the old upload flow used.
  • No visible change.

Related Issues

N/A

Related Pull Requests

Last of the upload refactor stack. Depends on: upload to shared folders through the new upload flow (#2271).

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

The tests of the removed code are removed with it, and the retry list tests now cover failed downloads only. Typecheck, lint, the translations check and the whole test suite pass.

To check in the preview: run the acceptance criteria of PB-4449 (full upload regression) and retry a failed download.

Additional Notes

Deletion only, apart from the retry list and its tests.

@xabg2 xabg2 added the enhancement New feature or request label Nov 3, 2026
@xabg2 xabg2 self-assigned this Nov 3, 2026
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8857234
Status: ✅  Deploy successful!
Preview URL: https://0807352a.drive-web.pages.dev
Branch Preview URL: https://refactor-upload-legacy-clean.drive-web.pages.dev

View logs

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@xabg2

xabg2 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing this PR as we will split this in smaller ones once we deploy the refactor to production.

@xabg2 xabg2 closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant