Skip to content

[PB-6295]: fix/show a clear message when the login request fails - #2297

Draft
terrerox wants to merge 1 commit into
masterfrom
fix/login-error-message
Draft

terrerox wants to merge 1 commit into
masterfrom
fix/login-error-message

Conversation

@terrerox

@terrerox terrerox commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Description

The login form showed the raw error text, so a server or network failure displayed technical text instead of a clear message. Network failures and timeouts now show "Internet connection lost", and server errors and unreadable messages show "Internal server error. Try again later".

  • getLoginErrorMessage maps network failures and timeouts to error.connectionLostError, and 5xx, blank or garbled messages to error.serverError. Auth 4xx errors keep the server message unchanged.
  • castError in error.service uses the server message only when it is readable text, and still joins validation lists with ", ".
  • LogIn.tsx shows the result of getLoginErrorMessage in the login form.

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Network failures and timeouts now show "Internet connection lost".
Server errors and blank or unreadable messages show "Internal server
error. Try again later". Real login errors keep the server text.
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@terrerox terrerox self-assigned this Nov 6, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: c90d36c
Status: ✅  Deploy successful!
Preview URL: https://6157cb75.drive-web.pages.dev
Branch Preview URL: https://fix-login-error-message.drive-web.pages.dev

View logs

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant