Repository navigation
Conversation
Network failures and timeouts now show "Internet connection lost". Server errors and blank or unreadable messages show "Internal server error. Try again later". Real login errors keep the server text.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Deploying drive-web with
|
| Latest commit: |
c90d36c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6157cb75.drive-web.pages.dev |
| Branch Preview URL: | https://fix-login-error-message.drive-web.pages.dev |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The login form showed the raw error text, so a server or network failure displayed technical text instead of a clear message. Network failures and timeouts now show "Internet connection lost", and server errors and unreadable messages show "Internal server error. Try again later".
getLoginErrorMessagemaps network failures and timeouts toerror.connectionLostError, and 5xx, blank or garbled messages toerror.serverError. Auth 4xx errors keep the server message unchanged.castErrorinerror.serviceuses the server message only when it is readable text, and still joins validation lists with ", ".LogIn.tsxshows the result ofgetLoginErrorMessagein the login form.Checklist