Skip to content

refactor(webhooks): use the shared logger in webhook handlers - #424

Merged
xabg2 merged 1 commit into
masterfrom
refactor/webhook-events
Oct 26, 2026
Merged

xabg2 merged 1 commit into
masterfrom
refactor/webhook-events

Conversation

@xabg2

@xabg2 xabg2 commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

What's new

  • Stripe webhook events now log through the service's shared logger, with the same format and log level as the rest of the payments server.
  • No change in how Stripe events are processed.

@xabg2 xabg2 added the enhancement New feature or request label Oct 23, 2026
@xabg2 xabg2 self-assigned this Oct 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
63.5% Coverage on New Code (required ≥ 85%)

See analysis details on SonarQube Cloud

@xabg2
xabg2 marked this pull request as ready for review October 23, 2026 14:33
@xabg2
xabg2 requested review from jzunigax2 and sg-gs as code owners October 23, 2026 14:33

@sg-gs sg-gs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this seems harmless and the error surface is pretty short, but considering how critical is this service and the webhooks, I recommend to deploy this on Monday @xabg2

@xabg2

xabg2 commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

I understand that this seems harmless and the error surface is pretty short, but considering how critical is this service and the webhooks, I recommend to deploy this on Monday @xabg2

Ofc, I do not deploy things on Friday afternoon unless it is strictly necessary.

@xabg2
xabg2 merged commit 702a53d into master Oct 26, 2026
13 of 14 checks passed
@xabg2
xabg2 deleted the refactor/webhook-events branch October 26, 2026 08:35

This branch was previously deployed

1 inactive deployment
test — 06042d76 Deployed Oct 23, 2026 by xabg2 via SonarCloud (24.11.0) #1371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready-for-preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants