Repository navigation
refactor(stripe): read user invoices with the basil API version - #429
Merged
xabg2 merged 1 commit intoOct 28, 2026
Merged
Conversation
|
jzunigax2
reviewed
Oct 27, 2026
| limit: 100, | ||
| }); | ||
| const pricesById = await this.paymentsService.getPricesByIds( | ||
| invoices.map(getInvoicePriceId).filter((priceId): priceId is string => !!priceId), |
Contributor
There was a problem hiding this comment.
nit pick: I see this type guard repeated a bit. maybe extract it to utils and name what it does so its a bit more readable
Collaborator
Author
There was a problem hiding this comment.
Yep, we can do that, but I thought it is out of scope as I'm just trying to update the Stripe SDK. WDYT? I can do it, np.
Contributor
There was a problem hiding this comment.
ok sounds good, its still understandable so can be left as is
jzunigax2
approved these changes
Oct 27, 2026
| return getStripeNewVersion().charges.retrieve(chargeId); | ||
| } | ||
|
|
||
| async getPaymentIntent(paymentIntentId: Stripe.PaymentIntent['id']): Promise<Stripe.PaymentIntent> { |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Depends on #428.