Skip to content

refactor(stripe): use a single Stripe SDK on the basil API version - #432

Merged
xabg2 merged 2 commits into
refactor/stripe-basil-webhooksfrom
refactor/stripe-basil-final
Oct 28, 2026
Merged

xabg2 merged 2 commits into
refactor/stripe-basil-webhooksfrom
refactor/stripe-basil-final

Conversation

@xabg2

@xabg2 xabg2 commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

What's new

  • Payments now talk to Stripe through a single, up-to-date SDK on the latest API version, removing the old version that was still used for customers, prices, tax and other calls.
  • Paid and failed invoice events without an invoice are now ignored instead of failing.

Depends on #431

@xabg2 xabg2 added the enhancement New feature or request label Oct 26, 2026
@xabg2 xabg2 self-assigned this Oct 26, 2026
@xabg2
xabg2 added this pull request to stack #433 October 27, 2026 07:37
@sonarqubecloud

Copy link
Copy Markdown

@xabg2
xabg2 marked this pull request as ready for review October 27, 2026 09:38
@xabg2
xabg2 requested review from jzunigax2 and sg-gs as code owners October 27, 2026 09:38
jzunigax2
jzunigax2 previously approved these changes Oct 27, 2026

@jzunigax2 jzunigax2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right after deploying you'll update the stripe version in the dashboard right?

@xabg2

xabg2 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

right after deploying you'll update the stripe version in the dashboard right?

Exactly 🎯

@xabg2
xabg2 dismissed jzunigax2’s stale review October 28, 2026 08:30

The merge-base changed after approval.

@xabg2
xabg2 merged commit 88eaa73 into master Oct 28, 2026
14 checks passed
@xabg2
xabg2 deleted the refactor/stripe-basil-final branch October 28, 2026 08:30

This branch was previously deployed

1 inactive deployment
test — 4726531c Deployed Oct 27, 2026 by xabg2 via SonarCloud (24.11.0) #1382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready-for-preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants