Repository navigation
refactor(stripe): upgrade to the dahlia API version - #436
Merged
Merged
Conversation
|
xabg2
marked this pull request as ready for review
October 28, 2026 10:42
Member
|
Leaving this review up to you @jzunigax2 |
jzunigax2
previously approved these changes
Oct 30, 2026
|
|
||
| expect(response.statusCode).toBe(200); | ||
| expect(responseBody).toStrictEqual(mockedSubscription); | ||
| expect(responseBody).toStrictEqual(JSON.parse(JSON.stringify(mockedSubscription))); |
Contributor
There was a problem hiding this comment.
why the stringify then the parse?
Collaborator
Author
There was a problem hiding this comment.
With the dahlia API version, *_decimal fields are Stripe.Decimal instances instead of strings. The response serializes them to "1000", so comparing against the raw fixture fails on plan.amount_decimal. Round-tripping the fixture through JSON gives what the client actually receives.
jzunigax2
approved these changes
Nov 2, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Depends on #435