Skip to content

feat(auth): add optional withCredentials to Auth client - #454

Merged
apsantiso merged 1 commit into
masterfrom
feat/login-with-credentials
Nov 3, 2026
Merged

apsantiso merged 1 commit into
masterfrom
feat/login-with-credentials

Conversation

@apsantiso

@apsantiso apsantiso commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Why

Cloudflare uses cookies to tell apart users behind the same IP.

Browsers only store/send it cross-origin (drive.internxt.com → gateway.internxt.com) with withCredentials: true.

Changes

  • New HttpClientOptions { withCredentials?: boolean } (src/shared/http/types.ts).
  • HttpClient.create(..., options?) passes withCredentials to axios (default false).
  • Auth.client(apiUrl, appDetails, apiSecurity?, options?).

Lets browsers store and send Cloudflare _cfuvid cookie for rate limit IP with NAT support. Default false, no-op on Node/React Native.
@apsantiso apsantiso self-assigned this Nov 2, 2026
@apsantiso
apsantiso requested a review from CandelR November 2, 2026 17:14
@apsantiso
apsantiso marked this pull request as ready for review November 2, 2026 17:14
@apsantiso
apsantiso requested a review from sg-gs November 2, 2026 18:08
@apsantiso
apsantiso merged commit 4a09308 into master Nov 3, 2026
1 check passed
@apsantiso
apsantiso deleted the feat/login-with-credentials branch November 3, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants