codeql: paths-ignore 6 un-modelable java/sql-injection residuals #520-#525 (Task 8) - #43
Merged
Merged
Conversation
…-#525 (Task 8) The 6 remaining sql-injection alerts after PR #36 sit at JDBC sinks that already carry runtime SecureStringUtils guards on main (requireSqlObjectNameOrNull / requireSingleSqlStatement / requireFactorySqlStatement). GHAS does not load local model packs, so the in-repo sanitizer is not a recognized barrier, and it ignores // codeql[java/sql-injection] on or above the sink. Add 5 path-level residuals to codeql-config.yml paths-ignore + 6 suppressions.md rows (same mechanism as PR #36's #519/#526/#527): - PSJdbcResultSetIteratorStep.java #520 - PSJdbcTableFactory.java #521 - PSJdbcTableMetaData.java #522 #523 - PSOSimpleSqlQuery.java #524 - PSSQLStatement.java #525 No Java code changed - runtime guards already landed in PR #36. verify-suppressions.py: PASS (0 warnings).
4 tasks
Collaborator
Author
|
Superseded by #50 (consolidated onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes 6 CodeQL
java/sql-injectionHigh alerts (#520-#525) that remained open after PR #36 (Task 4).Why paths-ignore
Every sink already carries a runtime
SecureStringUtilsbarrier onmain(requireSqlObjectNameOrNull/requireSingleSqlStatement/requireFactorySqlStatement), but GHAS does not load local model packs, so the in-repo sanitizer is not a recognized barrier, and sink-line// codeql[java/sql-injection]comments are ignored. This is exactly the PR #36 residual situation (#519/#526/#527) — same rule family, same guard helpers, same path-level pattern.PSJdbcResultSetIteratorStep.javarequireFactorySqlStatement(m_statement)beforeexecuteQueryPSJdbcTableFactory.javarequireSqlObjectNameOrNull(tableSchema.getName())before COUNT(*)PSJdbcTableMetaData.javarequireSqlObjectNameOrNull(m_tableName/m_schema)beforegetColumnsPSJdbcTableMetaData.javagetPrimaryKeysPSOSimpleSqlQuery.javarequireSingleSqlStatement(query)beforeprepareStatementPSSQLStatement.javarequireSingleSqlStatement(sql)beforeexecuteQueryChanges
.github/codeql/codeql-config.yml— 5 newpaths-ignoreentries with justificationsuppressions.md— 6 new rows (verbatim justification convention;verify-suppressions.pyPASS, 0 warnings)CHANGELOG.md— Task 8 sql-injection residual entryNo Java code changed in this PR — the runtime guards were already landed in PR #36's sink hardening.
Verification
Notes
*.versionproperties untouched.Version.propertieswas not modified.