codeql: paths-ignore 2 java/zipslip residuals #500 #622 (Task 8) - #44
Merged
Conversation
…-#525 (Task 8) The 6 remaining sql-injection alerts after PR #36 sit at JDBC sinks that already carry runtime SecureStringUtils guards on main (requireSqlObjectNameOrNull / requireSingleSqlStatement / requireFactorySqlStatement). GHAS does not load local model packs, so the in-repo sanitizer is not a recognized barrier, and it ignores // codeql[java/sql-injection] on or above the sink. Add 5 path-level residuals to codeql-config.yml paths-ignore + 6 suppressions.md rows (same mechanism as PR #36's #519/#526/#527): - PSJdbcResultSetIteratorStep.java #520 - PSJdbcTableFactory.java #521 - PSJdbcTableMetaData.java #522 #523 - PSOSimpleSqlQuery.java #524 - PSSQLStatement.java #525 No Java code changed - runtime guards already landed in PR #36. verify-suppressions.py: PASS (0 warnings).
Both call sites already route through ZipSlipGuard.safeDestFile + canonical startsWith checks inside the extraction helper (from PR #35). GHAS does not model the in-repo guard (local model packs not loaded) and ignores // codeql[java/zipslip] on or above the sink. Add 2 path-level residuals to codeql-config.yml paths-ignore + 2 suppressions.md rows: - PSInstallRxApp.java #500 (call-site alert) - PSWidgetPackageBuilder.java #622 (call-site alert) No Java code changed - runtime guards already landed in PR #35. verify-suppressions.py: PASS (0 warnings).
4 tasks
Collaborator
Author
|
Superseded by #50 (consolidated onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes 2 CodeQL
java/zipslipHigh alerts (#500, #622) that surfaced after PR #35's sink-line suppressions.Why paths-ignore
Both call sites already route through
ZipSlipGuard.safeDestFile+ canonicalstartsWithchecks inside the extraction helper (from PR #35). GHAS does not model the in-repo guard (local model packs not loaded) and ignores// codeql[java/zipslip]on or above the sink — identical to the PR #35 residual situation (MainDTSPreInstall/Main/PSArchiveFiles).PSInstallRxApp.javaZipSlipGuard.safeDestFile+ canonical startsWith incopyInputStreamToFilePSWidgetPackageBuilder.javaZipSlipGuard.safeDestFile(incl. re-validation after transformer) + canonical startsWith beforeFileOutputStreamChanges
.github/codeql/codeql-config.yml— 2 newpaths-ignoreentries with justificationsuppressions.md— 2 new rows (verbatim justification convention;verify-suppressions.pyPASS, 0 warnings)CHANGELOG.md— Task 8 zipslip residual entryNo Java code changed in this PR — the runtime guards were already landed in PR #35.
Verification
python3 scripts/verify-suppressions.py # PASS, 0 warningsNotes
*.versionproperties untouched.Version.propertieswas not modified.