Repository navigation
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matmair
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13030 +/- ##
==========================================
+ Coverage 87.26% 87.32% +0.06%
==========================================
Files 1522 1522
Lines 105636 105507 -129
Branches 11890 11814 -76
==========================================
- Hits 92178 92138 -40
+ Misses 13391 13302 -89
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
@matmair I'd like this to have a bit more time on master, will merge after we release 1.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting back on the federation train again; While I have nothing ready to share I have found an issue: reliably identifying if the calling party is actually who they say, especially with forwarding proxies in play.
This PR adds a way to compute a nonce to proof in a replayable but somewhat time limited fashion. The same nonce for the same instance id changes every month this way. The used crypto id HKDF for instance shuffeling and then HMAC for proof calculations; both are widely used in things like ipsec so I am pretty confident that should be safe enough.
As every federation participant needs the root API responses anyway for compatibility checks I have added it as an optional query parameter to that response.